You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hive.apache.org by ab...@apache.org on 2022/08/03 20:03:00 UTC

[hive] branch master updated: HIVE-26444: Use tez.local.mode.without.network for unit tests (#3491) (Laszlo Bodor reviewed by Ayush Saxena, Stamatis Zampetakis)

This is an automated email from the ASF dual-hosted git repository.

abstractdog pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hive.git


The following commit(s) were added to refs/heads/master by this push:
     new 50fff5a396 HIVE-26444: Use tez.local.mode.without.network for unit tests (#3491) (Laszlo Bodor reviewed by Ayush Saxena, Stamatis Zampetakis)
50fff5a396 is described below

commit 50fff5a3962d662e1b00287a1f5f6e8d3283523f
Author: Bodor Laszlo <bo...@gmail.com>
AuthorDate: Wed Aug 3 22:02:48 2022 +0200

    HIVE-26444: Use tez.local.mode.without.network for unit tests (#3491) (Laszlo Bodor reviewed by Ayush Saxena, Stamatis Zampetakis)
---
 .../src/test/java/org/apache/iceberg/mr/hive/TestHiveShell.java        | 2 ++
 .../src/test/java/org/apache/hadoop/hive/ql/TestAcidOnTez.java         | 1 +
 .../org/apache/hadoop/hive/ql/txn/compactor/CompactorOnTezTest.java    | 1 +
 ql/src/test/org/apache/hive/testutils/HiveTestEnvSetup.java            | 1 +
 .../0.23/src/main/java/org/apache/hadoop/hive/shims/Hadoop23Shims.java | 3 ++-
 5 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/TestHiveShell.java b/iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/TestHiveShell.java
index d05d0bf250..f55324e865 100644
--- a/iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/TestHiveShell.java
+++ b/iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/TestHiveShell.java
@@ -201,6 +201,8 @@ public class TestHiveShell {
 
     // Tez configuration
     hiveConf.setBoolean("tez.local.mode", true);
+    // TODO: enable below option once HIVE-26445 is investigated
+    // hiveConf.setBoolean("tez.local.mode.without.network", true);
 
     // Disable vectorization for HiveIcebergInputFormat
     hiveConf.setBoolVar(HiveConf.ConfVars.HIVE_VECTORIZATION_ENABLED, false);
diff --git a/itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/TestAcidOnTez.java b/itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/TestAcidOnTez.java
index 5269638498..5671d4a6da 100644
--- a/itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/TestAcidOnTez.java
+++ b/itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/TestAcidOnTez.java
@@ -1008,6 +1008,7 @@ ekoifman:apache-hive-3.0.0-SNAPSHOT-bin ekoifman$ tree  ~/dev/hiverwgit/itests/h
     conf.set("tez.am.resource.memory.mb", "128");
     conf.set("tez.am.dag.scheduler.class", "org.apache.tez.dag.app.dag.impl.DAGSchedulerNaturalOrderControlled");
     conf.setBoolean("tez.local.mode", true);
+    conf.setBoolean("tez.local.mode.without.network", true);
     conf.set("fs.defaultFS", "file:///");
     conf.setBoolean("tez.runtime.optimize.local.fetch", true);
     conf.set("tez.staging-dir", TEST_DATA_DIR);
diff --git a/itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorOnTezTest.java b/itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorOnTezTest.java
index 10e88ca97b..e96b2fd611 100644
--- a/itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorOnTezTest.java
+++ b/itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorOnTezTest.java
@@ -112,6 +112,7 @@ public abstract class CompactorOnTezTest {
     conf.set("tez.am.dag.scheduler.class",
         "org.apache.tez.dag.app.dag.impl.DAGSchedulerNaturalOrderControlled");
     conf.setBoolean("tez.local.mode", true);
+    conf.setBoolean("tez.local.mode.without.network", true);
     conf.set("fs.defaultFS", "file:///");
     conf.setBoolean("tez.runtime.optimize.local.fetch", true);
     conf.set("tez.staging-dir", TEST_DATA_DIR);
diff --git a/ql/src/test/org/apache/hive/testutils/HiveTestEnvSetup.java b/ql/src/test/org/apache/hive/testutils/HiveTestEnvSetup.java
index 3acebe9d85..f098a217ef 100644
--- a/ql/src/test/org/apache/hive/testutils/HiveTestEnvSetup.java
+++ b/ql/src/test/org/apache/hive/testutils/HiveTestEnvSetup.java
@@ -247,6 +247,7 @@ public class HiveTestEnvSetup extends ExternalResource {
       conf.set("tez.am.resource.memory.mb", "128");
       conf.set("tez.am.dag.scheduler.class", "org.apache.tez.dag.app.dag.impl.DAGSchedulerNaturalOrderControlled");
       conf.setBoolean("tez.local.mode", true);
+      conf.setBoolean("tez.local.mode.without.network", true);
       conf.set("fs.defaultFS", "file:///");
       conf.setBoolean("tez.runtime.optimize.local.fetch", true);
       conf.set("tez.staging-dir", TEST_DATA_DIR);
diff --git a/shims/0.23/src/main/java/org/apache/hadoop/hive/shims/Hadoop23Shims.java b/shims/0.23/src/main/java/org/apache/hadoop/hive/shims/Hadoop23Shims.java
index a73c50253b..d102b02392 100644
--- a/shims/0.23/src/main/java/org/apache/hadoop/hive/shims/Hadoop23Shims.java
+++ b/shims/0.23/src/main/java/org/apache/hadoop/hive/shims/Hadoop23Shims.java
@@ -366,7 +366,8 @@ public class Hadoop23Shims extends HadoopShimsSecure {
     @Override
     public void setupConfiguration(Configuration conf) {
       conf.setBoolean(TezConfiguration.TEZ_LOCAL_MODE, true);
-
+      // TODO: enable below option once HIVE-26445 is investigated
+      // hiveConf.setBoolean("tez.local.mode.without.network", true);
       conf.setBoolean(TezRuntimeConfiguration.TEZ_RUNTIME_OPTIMIZE_LOCAL_FETCH, true);
 
       conf.setBoolean(TezConfiguration.TEZ_IGNORE_LIB_URIS, true);