You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by mr...@apache.org on 2019/12/21 01:27:59 UTC
[arrow] branch master updated: ARROW-7452: [GLib] Make
GArrowTimeDataType abstract
This is an automated email from the ASF dual-hosted git repository.
mrkn pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/master by this push:
new dad9c88 ARROW-7452: [GLib] Make GArrowTimeDataType abstract
dad9c88 is described below
commit dad9c887f30c60e4c4b3ff32f244df83346b8751
Author: Sutou Kouhei <ko...@clear-code.com>
AuthorDate: Sat Dec 21 10:27:34 2019 +0900
ARROW-7452: [GLib] Make GArrowTimeDataType abstract
Closes #6074 from kou/glib-make-time-data-type-abstract and squashes the following commits:
3dfc43cbe <Sutou Kouhei> Make GArrowTimeDataType abstract
Authored-by: Sutou Kouhei <ko...@clear-code.com>
Signed-off-by: Kenta Murata <mr...@mrkn.jp>
---
c_glib/arrow-glib/basic-data-type.cpp | 6 +++---
c_glib/test/test-time-data-type.rb | 24 ++++++++++++++++++++++++
2 files changed, 27 insertions(+), 3 deletions(-)
diff --git a/c_glib/arrow-glib/basic-data-type.cpp b/c_glib/arrow-glib/basic-data-type.cpp
index db9551c..f86b24f 100644
--- a/c_glib/arrow-glib/basic-data-type.cpp
+++ b/c_glib/arrow-glib/basic-data-type.cpp
@@ -1018,9 +1018,9 @@ garrow_timestamp_data_type_get_unit(GArrowTimestampDataType *timestamp_data_type
}
-G_DEFINE_TYPE(GArrowTimeDataType,
- garrow_time_data_type,
- GARROW_TYPE_DATA_TYPE)
+G_DEFINE_ABSTRACT_TYPE(GArrowTimeDataType,
+ garrow_time_data_type,
+ GARROW_TYPE_DATA_TYPE)
static void
garrow_time_data_type_init(GArrowTimeDataType *object)
diff --git a/c_glib/test/test-time-data-type.rb b/c_glib/test/test-time-data-type.rb
new file mode 100644
index 0000000..a7b1503
--- /dev/null
+++ b/c_glib/test/test-time-data-type.rb
@@ -0,0 +1,24 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+class TestTimeDataType < Test::Unit::TestCase
+ def test_type
+ assert do
+ Arrow::TimeDataType.gtype.abstract?
+ end
+ end
+end