[GitHub] [kafka] dajac commented on a diff in pull request #13675: KAFKA-14462; [14/N] Add PartitionWriter

["dajac (via GitHub)" <gi...@apache.org>]

dajac commented on code in PR #13675:
URL: https://github.com/apache/kafka/pull/13675#discussion_r1213267178


##########
core/src/main/scala/kafka/server/ReplicaManager.scala:
##########
@@ -1019,13 +1029,14 @@ class ReplicaManager(val config: KafkaConfig,
   }
 
   /**
-   * Append the messages to the local replica logs
+   * Append the messages to the local replica logs. ReplicaManager#appendRecords should usually be
+   * used instead of this method.

Review Comment:
   I did not use it here because it put stuff to the action queue and I don't want/need this in my case. Let me circle back on this to see if can do better. I wrote this a while ago and I admit that I went with the easiest solution back then.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org