You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2019/12/03 14:06:30 UTC
Review Request 71856: Added resource limits into `ContainerConfig`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71856/
-----------------------------------------------------------
Review request for mesos, Andrei Budnik and Greg Mann.
Bugs: MESOS-10046
https://issues.apache.org/jira/browse/MESOS-10046
Repository: mesos
Description
-------
Added resource limits into `ContainerConfig`.
Diffs
-----
include/mesos/slave/containerizer.proto 8b1a268b5ddf1b791c47219355143da8dbd03789
Diff: https://reviews.apache.org/r/71856/diff/1/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 71856: Added resource limits into
`ContainerConfig`.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71856/#review219079
-----------------------------------------------------------
Fix it, then Ship it!
include/mesos/slave/containerizer.proto
Lines 144 (patched)
<https://reviews.apache.org/r/71856/#comment307140>
s/Resources/Resource/
- Greg Mann
On Dec. 20, 2019, 2:11 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71856/
> -----------------------------------------------------------
>
> (Updated Dec. 20, 2019, 2:11 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Greg Mann.
>
>
> Bugs: MESOS-10046
> https://issues.apache.org/jira/browse/MESOS-10046
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added resource limits into `ContainerConfig`.
>
>
> Diffs
> -----
>
> include/mesos/slave/containerizer.proto 8b1a268b5ddf1b791c47219355143da8dbd03789
>
>
> Diff: https://reviews.apache.org/r/71856/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 71856: Added resource limits into
`ContainerConfig`.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71856/
-----------------------------------------------------------
(Updated Dec. 23, 2019, 2:56 p.m.)
Review request for mesos, Andrei Budnik and Greg Mann.
Changes
-------
Addressed review comments.
Bugs: MESOS-10046
https://issues.apache.org/jira/browse/MESOS-10046
Repository: mesos
Description
-------
Added resource limits into `ContainerConfig`.
Diffs (updated)
-----
include/mesos/slave/containerizer.proto 8b1a268b5ddf1b791c47219355143da8dbd03789
Diff: https://reviews.apache.org/r/71856/diff/2/
Changes: https://reviews.apache.org/r/71856/diff/1-2/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 71856: Added resource limits into
`ContainerConfig`.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71856/
-----------------------------------------------------------
(Updated Dec. 20, 2019, 10:11 a.m.)
Review request for mesos, Andrei Budnik and Greg Mann.
Bugs: MESOS-10046
https://issues.apache.org/jira/browse/MESOS-10046
Repository: mesos
Description
-------
Added resource limits into `ContainerConfig`.
Diffs
-----
include/mesos/slave/containerizer.proto 8b1a268b5ddf1b791c47219355143da8dbd03789
Diff: https://reviews.apache.org/r/71856/diff/1/
Testing
-------
Thanks,
Qian Zhang