You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "Antoine Pitrou (Jira)" <ji...@apache.org> on 2021/03/09 15:17:00 UTC
[jira] [Resolved] (ARROW-11680) [C++] Add vendored version of
folly's spsc queue
[ https://issues.apache.org/jira/browse/ARROW-11680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antoine Pitrou resolved ARROW-11680.
------------------------------------
Fix Version/s: 4.0.0
Resolution: Fixed
Issue resolved by pull request 9519
[https://github.com/apache/arrow/pull/9519]
> [C++] Add vendored version of folly's spsc queue
> ------------------------------------------------
>
> Key: ARROW-11680
> URL: https://issues.apache.org/jira/browse/ARROW-11680
> Project: Apache Arrow
> Issue Type: Sub-task
> Components: C++
> Reporter: Weston Pace
> Assignee: Weston Pace
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> Rationale for vendoring:
> Folly contains hundreds of files, requires boost & C++14. The ProducerConsumerQueue class could be extracted out of three of those files and hasn't been changed since 2018. The queue does not appear to have any open issues.
> Comparisons with alternatives:
> I have included a benchmark comparing folly with boost (since boost::lockfree::spsc_queue is already included in arrow, I think). Boost does not support a move workflow for spsc_queue and performs worse.
> I have not compared with any other alternatives but the utility is small and straightforward enough I am doubtful there would be significant differences.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)