You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Junping Du (Created) (JIRA)" <ji...@apache.org> on 2012/03/06 17:26:57 UTC

[jira] [Created] (HADOOP-8144) pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node

pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node
----------------------------------------------------------------------------------------------------------------

                 Key: HADOOP-8144
                 URL: https://issues.apache.org/jira/browse/HADOOP-8144
             Project: Hadoop Common
          Issue Type: Bug
          Components: io
    Affects Versions: 1.0.0, 0.23.0
            Reporter: Junping Du
            Priority: Minor


pseudoSortByDistance in NetworkTopology.java should sort nodes according to its distance with reader as local node, local rack node, ... 
But if there is no local node with reader in nodes and the first node is local rack node with reader, then it will put a random node at position 0.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8144) pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13435028#comment-13435028 ] 

Hudson commented on HADOOP-8144:
--------------------------------

Integrated in Hadoop-Hdfs-0.23-Build #344 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/344/])
    svn merge -c 1330613 FIXES: HDFS-3258. Test for HADOOP-8144 (pseudoSortByDistance in NetworkTopology for first rack local node). Contributed by Junping Du (Revision 1372956)
svn merge -c 1325367 FIXES: HADOOP-8144. pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node. Contributed by Junping Du (Revision 1372955)

     Result = SUCCESS
daryn : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1372956
Files : 
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/net/TestNetworkTopology.java

bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1372955
Files : 
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetworkTopology.java

                
> pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-8144
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8144
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 1.0.0, 0.23.0
>            Reporter: Junping Du
>            Assignee: Junping Du
>            Priority: Minor
>              Labels: patch
>             Fix For: 0.23.3, 2.0.0-alpha
>
>         Attachments: HADOOP-8144-1.patch, hadoop-8144.txt, hadoop-8144.txt, HADOOP-8144-v2.patch
>
>
> pseudoSortByDistance in NetworkTopology.java should sort nodes according to its distance with reader as local node, local rack node, ... 
> But if there is no local node with reader in nodes and the first node is local rack node with reader, then it will put a random node at position 0.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8144) pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13262601#comment-13262601 ] 

Hudson commented on HADOOP-8144:
--------------------------------

Integrated in Hadoop-Hdfs-trunk #1026 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1026/])
    HDFS-3258. Test for HADOOP-8144 (pseudoSortByDistance in NetworkTopology for first rack local node). Contributed by Junping Du (Revision 1330613)

     Result = FAILURE
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1330613
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/net/TestNetworkTopology.java

                
> pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-8144
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8144
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 1.0.0, 0.23.0
>            Reporter: Junping Du
>            Assignee: Junping Du
>            Priority: Minor
>              Labels: patch
>             Fix For: 2.0.0
>
>         Attachments: HADOOP-8144-1.patch, HADOOP-8144-v2.patch, hadoop-8144.txt, hadoop-8144.txt
>
>
> pseudoSortByDistance in NetworkTopology.java should sort nodes according to its distance with reader as local node, local rack node, ... 
> But if there is no local node with reader in nodes and the first node is local rack node with reader, then it will put a random node at position 0.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8144) pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252671#comment-13252671 ] 

Hudson commented on HADOOP-8144:
--------------------------------

Integrated in Hadoop-Mapreduce-trunk-Commit #2076 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2076/])
    HADOOP-8144. pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node. Contributed by Junping Du (Revision 1325367)

     Result = ABORTED
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1325367
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetworkTopology.java

                
> pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-8144
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8144
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 1.0.0, 0.23.0
>            Reporter: Junping Du
>            Assignee: Junping Du
>            Priority: Minor
>              Labels: patch
>             Fix For: 2.0.0
>
>         Attachments: HADOOP-8144-1.patch, HADOOP-8144-v2.patch, hadoop-8144.txt, hadoop-8144.txt
>
>
> pseudoSortByDistance in NetworkTopology.java should sort nodes according to its distance with reader as local node, local rack node, ... 
> But if there is no local node with reader in nodes and the first node is local rack node with reader, then it will put a random node at position 0.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8144) pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node

Posted by "Junping Du (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Junping Du updated HADOOP-8144:
-------------------------------

              Labels: patch  (was: )
    Target Version/s: 0.23.1
              Status: Patch Available  (was: Open)
    
> pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-8144
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8144
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 1.0.0, 0.23.0
>            Reporter: Junping Du
>            Priority: Minor
>              Labels: patch
>         Attachments: HADOOP-8144-1.patch
>
>
> pseudoSortByDistance in NetworkTopology.java should sort nodes according to its distance with reader as local node, local rack node, ... 
> But if there is no local node with reader in nodes and the first node is local rack node with reader, then it will put a random node at position 0.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8144) pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253346#comment-13253346 ] 

Hudson commented on HADOOP-8144:
--------------------------------

Integrated in Hadoop-Hdfs-trunk #1013 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1013/])
    HADOOP-8144. pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node. Contributed by Junping Du (Revision 1325367)

     Result = FAILURE
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1325367
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetworkTopology.java

                
> pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-8144
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8144
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 1.0.0, 0.23.0
>            Reporter: Junping Du
>            Assignee: Junping Du
>            Priority: Minor
>              Labels: patch
>             Fix For: 2.0.0
>
>         Attachments: HADOOP-8144-1.patch, HADOOP-8144-v2.patch, hadoop-8144.txt, hadoop-8144.txt
>
>
> pseudoSortByDistance in NetworkTopology.java should sort nodes according to its distance with reader as local node, local rack node, ... 
> But if there is no local node with reader in nodes and the first node is local rack node with reader, then it will put a random node at position 0.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8144) pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node

Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Joseph Evans updated HADOOP-8144:
----------------------------------------

    Fix Version/s: 0.23.3

I checked this into branch-0.23 too.
                
> pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-8144
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8144
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 1.0.0, 0.23.0
>            Reporter: Junping Du
>            Assignee: Junping Du
>            Priority: Minor
>              Labels: patch
>             Fix For: 0.23.3, 2.0.0-alpha
>
>         Attachments: HADOOP-8144-1.patch, hadoop-8144.txt, hadoop-8144.txt, HADOOP-8144-v2.patch
>
>
> pseudoSortByDistance in NetworkTopology.java should sort nodes according to its distance with reader as local node, local rack node, ... 
> But if there is no local node with reader in nodes and the first node is local rack node with reader, then it will put a random node at position 0.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8144) pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node

Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13232435#comment-13232435 ] 

Hadoop QA commented on HADOOP-8144:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12517255/HADOOP-8144-1.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/725//console

This message is automatically generated.
                
> pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-8144
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8144
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 0.23.0, 1.0.0
>            Reporter: Junping Du
>            Priority: Minor
>              Labels: patch
>         Attachments: HADOOP-8144-1.patch
>
>
> pseudoSortByDistance in NetworkTopology.java should sort nodes according to its distance with reader as local node, local rack node, ... 
> But if there is no local node with reader in nodes and the first node is local rack node with reader, then it will put a random node at position 0.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8144) pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node

Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252040#comment-13252040 ] 

Hadoop QA commented on HADOOP-8144:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12522341/hadoop-8144.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 1 new or modified test files.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/846//console

This message is automatically generated.
                
> pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-8144
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8144
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 1.0.0, 0.23.0
>            Reporter: Junping Du
>            Assignee: Junping Du
>            Priority: Minor
>              Labels: patch
>         Attachments: HADOOP-8144-1.patch, HADOOP-8144-v2.patch, hadoop-8144.txt
>
>
> pseudoSortByDistance in NetworkTopology.java should sort nodes according to its distance with reader as local node, local rack node, ... 
> But if there is no local node with reader in nodes and the first node is local rack node with reader, then it will put a random node at position 0.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (HADOOP-8144) pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node

Posted by "Eli Collins (Assigned) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eli Collins reassigned HADOOP-8144:
-----------------------------------

    Assignee: Junping Du
    
> pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-8144
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8144
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 1.0.0, 0.23.0
>            Reporter: Junping Du
>            Assignee: Junping Du
>            Priority: Minor
>              Labels: patch
>         Attachments: HADOOP-8144-1.patch, HADOOP-8144-v2.patch, hadoop-8144.txt
>
>
> pseudoSortByDistance in NetworkTopology.java should sort nodes according to its distance with reader as local node, local rack node, ... 
> But if there is no local node with reader in nodes and the first node is local rack node with reader, then it will put a random node at position 0.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8144) pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node

Posted by "Junping Du (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Junping Du updated HADOOP-8144:
-------------------------------

    Attachment: HADOOP-8144-v2.patch
    
> pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-8144
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8144
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 0.23.0, 1.0.0
>            Reporter: Junping Du
>            Priority: Minor
>              Labels: patch
>         Attachments: HADOOP-8144-1.patch, HADOOP-8144-v2.patch
>
>
> pseudoSortByDistance in NetworkTopology.java should sort nodes according to its distance with reader as local node, local rack node, ... 
> But if there is no local node with reader in nodes and the first node is local rack node with reader, then it will put a random node at position 0.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8144) pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13262293#comment-13262293 ] 

Hudson commented on HADOOP-8144:
--------------------------------

Integrated in Hadoop-Common-trunk-Commit #2135 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2135/])
    HDFS-3258. Test for HADOOP-8144 (pseudoSortByDistance in NetworkTopology for first rack local node). Contributed by Junping Du (Revision 1330613)

     Result = SUCCESS
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1330613
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/net/TestNetworkTopology.java

                
> pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-8144
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8144
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 1.0.0, 0.23.0
>            Reporter: Junping Du
>            Assignee: Junping Du
>            Priority: Minor
>              Labels: patch
>             Fix For: 2.0.0
>
>         Attachments: HADOOP-8144-1.patch, HADOOP-8144-v2.patch, hadoop-8144.txt, hadoop-8144.txt
>
>
> pseudoSortByDistance in NetworkTopology.java should sort nodes according to its distance with reader as local node, local rack node, ... 
> But if there is no local node with reader in nodes and the first node is local rack node with reader, then it will put a random node at position 0.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8144) pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node

Posted by "Eli Collins (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252557#comment-13252557 ] 

Eli Collins commented on HADOOP-8144:
-------------------------------------

Per discussion on HDFS-3258 the other bug (peudoSortByDistance does not take the "data center" layer into consideration) is independent.  I'll commit this and we'll update the test in HDFS-3258. 
                
> pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-8144
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8144
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 1.0.0, 0.23.0
>            Reporter: Junping Du
>            Assignee: Junping Du
>            Priority: Minor
>              Labels: patch
>             Fix For: 2.0.0
>
>         Attachments: HADOOP-8144-1.patch, HADOOP-8144-v2.patch, hadoop-8144.txt, hadoop-8144.txt
>
>
> pseudoSortByDistance in NetworkTopology.java should sort nodes according to its distance with reader as local node, local rack node, ... 
> But if there is no local node with reader in nodes and the first node is local rack node with reader, then it will put a random node at position 0.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8144) pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node

Posted by "Junping Du (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13232562#comment-13232562 ] 

Junping Du commented on HADOOP-8144:
------------------------------------

Update the patch on latest version of trunk.
                
> pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-8144
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8144
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 0.23.0, 1.0.0
>            Reporter: Junping Du
>            Priority: Minor
>              Labels: patch
>         Attachments: HADOOP-8144-1.patch, HADOOP-8144-v2.patch
>
>
> pseudoSortByDistance in NetworkTopology.java should sort nodes according to its distance with reader as local node, local rack node, ... 
> But if there is no local node with reader in nodes and the first node is local rack node with reader, then it will put a random node at position 0.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8144) pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node

Posted by "Eli Collins (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eli Collins updated HADOOP-8144:
--------------------------------

    Attachment: hadoop-8144.txt

Nice find Junping.  +1 patch looks great, pending jenkins.  Re-attaching the patch to kick jenkins.
                
> pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-8144
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8144
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 1.0.0, 0.23.0
>            Reporter: Junping Du
>            Priority: Minor
>              Labels: patch
>         Attachments: HADOOP-8144-1.patch, HADOOP-8144-v2.patch, hadoop-8144.txt
>
>
> pseudoSortByDistance in NetworkTopology.java should sort nodes according to its distance with reader as local node, local rack node, ... 
> But if there is no local node with reader in nodes and the first node is local rack node with reader, then it will put a random node at position 0.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8144) pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node

Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13232563#comment-13232563 ] 

Hadoop QA commented on HADOOP-8144:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12518889/HADOOP-8144-v2.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/727//console

This message is automatically generated.
                
> pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-8144
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8144
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 0.23.0, 1.0.0
>            Reporter: Junping Du
>            Priority: Minor
>              Labels: patch
>         Attachments: HADOOP-8144-1.patch, HADOOP-8144-v2.patch
>
>
> pseudoSortByDistance in NetworkTopology.java should sort nodes according to its distance with reader as local node, local rack node, ... 
> But if there is no local node with reader in nodes and the first node is local rack node with reader, then it will put a random node at position 0.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8144) pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252572#comment-13252572 ] 

Hudson commented on HADOOP-8144:
--------------------------------

Integrated in Hadoop-Common-trunk-Commit #2062 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2062/])
    HADOOP-8144. pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node. Contributed by Junping Du (Revision 1325367)

     Result = SUCCESS
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1325367
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetworkTopology.java

                
> pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-8144
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8144
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 1.0.0, 0.23.0
>            Reporter: Junping Du
>            Assignee: Junping Du
>            Priority: Minor
>              Labels: patch
>             Fix For: 2.0.0
>
>         Attachments: HADOOP-8144-1.patch, HADOOP-8144-v2.patch, hadoop-8144.txt, hadoop-8144.txt
>
>
> pseudoSortByDistance in NetworkTopology.java should sort nodes according to its distance with reader as local node, local rack node, ... 
> But if there is no local node with reader in nodes and the first node is local rack node with reader, then it will put a random node at position 0.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8144) pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node

Posted by "Junping Du (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13223430#comment-13223430 ] 

Junping Du commented on HADOOP-8144:
------------------------------------

The patch fix the issue when there is no local node and local rack node is happen to be position 0. The updated Unit Test with testPseudoSortByDistance can show this fix.
                
> pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-8144
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8144
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 0.23.0, 1.0.0
>            Reporter: Junping Du
>            Priority: Minor
>         Attachments: HADOOP-8144-1.patch
>
>
> pseudoSortByDistance in NetworkTopology.java should sort nodes according to its distance with reader as local node, local rack node, ... 
> But if there is no local node with reader in nodes and the first node is local rack node with reader, then it will put a random node at position 0.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8144) pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node

Posted by "Junping Du (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Junping Du updated HADOOP-8144:
-------------------------------

    Attachment: HADOOP-8144-1.patch
    
> pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-8144
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8144
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 0.23.0, 1.0.0
>            Reporter: Junping Du
>            Priority: Minor
>         Attachments: HADOOP-8144-1.patch
>
>
> pseudoSortByDistance in NetworkTopology.java should sort nodes according to its distance with reader as local node, local rack node, ... 
> But if there is no local node with reader in nodes and the first node is local rack node with reader, then it will put a random node at position 0.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8144) pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node

Posted by "Eli Collins (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252080#comment-13252080 ] 

Eli Collins commented on HADOOP-8144:
-------------------------------------

Hey Junping,

Thanks for contributing!  Looks like your test in HDFS-3258 found another bug, it yields in order 1,5,3 even with your patch (which I think is correct). Mind taking a look?
                
> pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-8144
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8144
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 1.0.0, 0.23.0
>            Reporter: Junping Du
>            Assignee: Junping Du
>            Priority: Minor
>              Labels: patch
>         Attachments: HADOOP-8144-1.patch, HADOOP-8144-v2.patch, hadoop-8144.txt, hadoop-8144.txt
>
>
> pseudoSortByDistance in NetworkTopology.java should sort nodes according to its distance with reader as local node, local rack node, ... 
> But if there is no local node with reader in nodes and the first node is local rack node with reader, then it will put a random node at position 0.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8144) pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13262301#comment-13262301 ] 

Hudson commented on HADOOP-8144:
--------------------------------

Integrated in Hadoop-Mapreduce-trunk-Commit #2152 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2152/])
    HDFS-3258. Test for HADOOP-8144 (pseudoSortByDistance in NetworkTopology for first rack local node). Contributed by Junping Du (Revision 1330613)

     Result = SUCCESS
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1330613
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/net/TestNetworkTopology.java

                
> pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-8144
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8144
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 1.0.0, 0.23.0
>            Reporter: Junping Du
>            Assignee: Junping Du
>            Priority: Minor
>              Labels: patch
>             Fix For: 2.0.0
>
>         Attachments: HADOOP-8144-1.patch, HADOOP-8144-v2.patch, hadoop-8144.txt, hadoop-8144.txt
>
>
> pseudoSortByDistance in NetworkTopology.java should sort nodes according to its distance with reader as local node, local rack node, ... 
> But if there is no local node with reader in nodes and the first node is local rack node with reader, then it will put a random node at position 0.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8144) pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13262615#comment-13262615 ] 

Hudson commented on HADOOP-8144:
--------------------------------

Integrated in Hadoop-Mapreduce-trunk #1061 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1061/])
    HDFS-3258. Test for HADOOP-8144 (pseudoSortByDistance in NetworkTopology for first rack local node). Contributed by Junping Du (Revision 1330613)

     Result = FAILURE
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1330613
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/net/TestNetworkTopology.java

                
> pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-8144
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8144
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 1.0.0, 0.23.0
>            Reporter: Junping Du
>            Assignee: Junping Du
>            Priority: Minor
>              Labels: patch
>             Fix For: 2.0.0
>
>         Attachments: HADOOP-8144-1.patch, HADOOP-8144-v2.patch, hadoop-8144.txt, hadoop-8144.txt
>
>
> pseudoSortByDistance in NetworkTopology.java should sort nodes according to its distance with reader as local node, local rack node, ... 
> But if there is no local node with reader in nodes and the first node is local rack node with reader, then it will put a random node at position 0.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8144) pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node

Posted by "Junping Du (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252138#comment-13252138 ] 

Junping Du commented on HADOOP-8144:
------------------------------------

Hi Eli,
   Sure. I will take a look at soon.

Thanks,

Junping
                
> pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-8144
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8144
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 1.0.0, 0.23.0
>            Reporter: Junping Du
>            Assignee: Junping Du
>            Priority: Minor
>              Labels: patch
>         Attachments: HADOOP-8144-1.patch, HADOOP-8144-v2.patch, hadoop-8144.txt, hadoop-8144.txt
>
>
> pseudoSortByDistance in NetworkTopology.java should sort nodes according to its distance with reader as local node, local rack node, ... 
> But if there is no local node with reader in nodes and the first node is local rack node with reader, then it will put a random node at position 0.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8144) pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253386#comment-13253386 ] 

Hudson commented on HADOOP-8144:
--------------------------------

Integrated in Hadoop-Mapreduce-trunk #1048 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1048/])
    HADOOP-8144. pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node. Contributed by Junping Du (Revision 1325367)

     Result = SUCCESS
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1325367
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetworkTopology.java

                
> pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-8144
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8144
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 1.0.0, 0.23.0
>            Reporter: Junping Du
>            Assignee: Junping Du
>            Priority: Minor
>              Labels: patch
>             Fix For: 2.0.0
>
>         Attachments: HADOOP-8144-1.patch, HADOOP-8144-v2.patch, hadoop-8144.txt, hadoop-8144.txt
>
>
> pseudoSortByDistance in NetworkTopology.java should sort nodes according to its distance with reader as local node, local rack node, ... 
> But if there is no local node with reader in nodes and the first node is local rack node with reader, then it will put a random node at position 0.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8144) pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252575#comment-13252575 ] 

Hudson commented on HADOOP-8144:
--------------------------------

Integrated in Hadoop-Hdfs-trunk-Commit #2136 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2136/])
    HADOOP-8144. pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node. Contributed by Junping Du (Revision 1325367)

     Result = SUCCESS
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1325367
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetworkTopology.java

                
> pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-8144
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8144
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 1.0.0, 0.23.0
>            Reporter: Junping Du
>            Assignee: Junping Du
>            Priority: Minor
>              Labels: patch
>             Fix For: 2.0.0
>
>         Attachments: HADOOP-8144-1.patch, HADOOP-8144-v2.patch, hadoop-8144.txt, hadoop-8144.txt
>
>
> pseudoSortByDistance in NetworkTopology.java should sort nodes according to its distance with reader as local node, local rack node, ... 
> But if there is no local node with reader in nodes and the first node is local rack node with reader, then it will put a random node at position 0.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8144) pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node

Posted by "Eli Collins (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eli Collins updated HADOOP-8144:
--------------------------------

          Resolution: Fixed
       Fix Version/s: 2.0.0
    Target Version/s:   (was: 0.23.1)
        Hadoop Flags: Reviewed
              Status: Resolved  (was: Patch Available)

I've committed this and merged to branch-2. Thanks Junping!
                
> pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-8144
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8144
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 1.0.0, 0.23.0
>            Reporter: Junping Du
>            Assignee: Junping Du
>            Priority: Minor
>              Labels: patch
>             Fix For: 2.0.0
>
>         Attachments: HADOOP-8144-1.patch, HADOOP-8144-v2.patch, hadoop-8144.txt, hadoop-8144.txt
>
>
> pseudoSortByDistance in NetworkTopology.java should sort nodes according to its distance with reader as local node, local rack node, ... 
> But if there is no local node with reader in nodes and the first node is local rack node with reader, then it will put a random node at position 0.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8144) pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node

Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252074#comment-13252074 ] 

Hadoop QA commented on HADOOP-8144:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12522348/hadoop-8144.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/848//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/848//console

This message is automatically generated.
                
> pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-8144
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8144
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 1.0.0, 0.23.0
>            Reporter: Junping Du
>            Assignee: Junping Du
>            Priority: Minor
>              Labels: patch
>         Attachments: HADOOP-8144-1.patch, HADOOP-8144-v2.patch, hadoop-8144.txt, hadoop-8144.txt
>
>
> pseudoSortByDistance in NetworkTopology.java should sort nodes according to its distance with reader as local node, local rack node, ... 
> But if there is no local node with reader in nodes and the first node is local rack node with reader, then it will put a random node at position 0.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8144) pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node

Posted by "Eli Collins (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eli Collins updated HADOOP-8144:
--------------------------------

    Attachment: hadoop-8144.txt

Same patch, just the common side. Filed HDFS-3258 for the test.
                
> pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-8144
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8144
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 1.0.0, 0.23.0
>            Reporter: Junping Du
>            Assignee: Junping Du
>            Priority: Minor
>              Labels: patch
>         Attachments: HADOOP-8144-1.patch, HADOOP-8144-v2.patch, hadoop-8144.txt, hadoop-8144.txt
>
>
> pseudoSortByDistance in NetworkTopology.java should sort nodes according to its distance with reader as local node, local rack node, ... 
> But if there is no local node with reader in nodes and the first node is local rack node with reader, then it will put a random node at position 0.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8144) pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13262290#comment-13262290 ] 

Hudson commented on HADOOP-8144:
--------------------------------

Integrated in Hadoop-Hdfs-trunk-Commit #2209 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2209/])
    HDFS-3258. Test for HADOOP-8144 (pseudoSortByDistance in NetworkTopology for first rack local node). Contributed by Junping Du (Revision 1330613)

     Result = SUCCESS
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1330613
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/net/TestNetworkTopology.java

                
> pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-8144
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8144
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 1.0.0, 0.23.0
>            Reporter: Junping Du
>            Assignee: Junping Du
>            Priority: Minor
>              Labels: patch
>             Fix For: 2.0.0
>
>         Attachments: HADOOP-8144-1.patch, HADOOP-8144-v2.patch, hadoop-8144.txt, hadoop-8144.txt
>
>
> pseudoSortByDistance in NetworkTopology.java should sort nodes according to its distance with reader as local node, local rack node, ... 
> But if there is no local node with reader in nodes and the first node is local rack node with reader, then it will put a random node at position 0.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira