You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-commits@jackrabbit.apache.org by ch...@apache.org on 2014/07/24 06:51:08 UTC
svn commit: r1612993 -
/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/IndexUpdate.java
Author: chetanm
Date: Thu Jul 24 04:51:07 2014
New Revision: 1612993
URL: http://svn.apache.org/r1612993
Log:
OAK-1986 - Log index names for which AsyncIndexUpdate would trigger a full reindex
Modified:
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/IndexUpdate.java
Modified: jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/IndexUpdate.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/IndexUpdate.java?rev=1612993&r1=1612992&r2=1612993&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/IndexUpdate.java (original)
+++ jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/IndexUpdate.java Thu Jul 24 04:51:07 2014
@@ -46,8 +46,11 @@ import org.apache.jackrabbit.oak.spi.sta
import org.apache.jackrabbit.oak.spi.state.NodeState;
import com.google.common.base.Objects;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
public class IndexUpdate implements Editor {
+ private final Logger log = LoggerFactory.getLogger(getClass());
private final IndexEditorProvider provider;
@@ -110,6 +113,10 @@ public class IndexUpdate implements Edit
throws CommitFailedException {
collectIndexEditors(builder.getChildNode(INDEX_DEFINITIONS_NAME), before);
+ if(!reindex.isEmpty()){
+ log.info("Reindexing would be performed for following indexes {}", reindex.keySet());
+ }
+
// no-op when reindex is empty
CommitFailedException exception = EditorDiff.process(
CompositeEditor.compose(reindex.values()), MISSING_NODE, after);
@@ -130,7 +137,11 @@ public class IndexUpdate implements Edit
}
// reindex in the case this is a new node, even though the reindex flag
// might be set to 'false' (possible via content import)
- return !before.getChildNode(INDEX_DEFINITIONS_NAME).hasChildNode(name);
+ boolean result = !before.getChildNode(INDEX_DEFINITIONS_NAME).hasChildNode(name);
+ if(result){
+ log.info("Found a new index node [{}]. Reindexing would be requested", name);
+ }
+ return result;
}
private void collectIndexEditors(NodeBuilder definitions,