[GitHub] [incubator-tvm] t-vi commented on a change in pull request #4394: add GPU checking before compilation for rocm

[GitBox <gi...@apache.org>]

t-vi commented on a change in pull request #4394: add GPU checking before compilation for rocm
URL: https://github.com/apache/incubator-tvm/pull/4394#discussion_r349039434
 
 

 ##########
 File path: python/tvm/autotvm/measure/measure_methods.py
 ##########
 @@ -227,7 +227,8 @@ def set_task(self, task):
 
     def get_build_kwargs(self):
         kwargs = {}
-        if 'cuda' in self.task.target.keys or 'opencl' in self.task.target.keys:
+        if 'cuda' in self.task.target.keys or 'opencl' in self.task.target.keys or \
+           'rocm in self.task.target.keys':
 
 Review comment:
   Ohoh.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services