You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Alex Blewitt (JIRA)" <ji...@apache.org> on 2007/03/26 21:51:32 UTC

[jira] Created: (HARMONY-3499) [classlib][pack200] Ongoing implementation of pack200

[classlib][pack200] Ongoing implementation of pack200
-----------------------------------------------------

                 Key: HARMONY-3499
                 URL: https://issues.apache.org/jira/browse/HARMONY-3499
             Project: Harmony
          Issue Type: Improvement
          Components: Classlib
            Reporter: Alex Blewitt
            Priority: Minor


This adds support for a few new bits and pieces. They aren't all related in this suite of patches, but I want to get them in before I submit changes for some of the larger parts.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-3499) [classlib][pack200] Ongoing implementation of pack200

Posted by "Alex Blewitt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Blewitt updated HARMONY-3499:
----------------------------------

    Attachment: 3-newfiles.zip

This contains two new files:

src/main/java/org/apache/harmony/pack200/bytecode/ByteCode.java
src/test/java/org/apache/harmony/pack200/tests/bytecode/ByteCodeTest.java

I seem to recall that this refers to files in 1-newfiles.zip (e.g. IMatcher) but can't be sure.



> [classlib][pack200] Ongoing implementation of pack200
> -----------------------------------------------------
>
>                 Key: HARMONY-3499
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3499
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Alex Blewitt
>            Priority: Minor
>         Attachments: 1-newfiles.zip, 2-CPRef.diff, 2-CPRefs.zip, 3-newfiles.zip
>
>
> This adds support for a few new bits and pieces. They aren't all related in this suite of patches, but I want to get them in before I submit changes for some of the larger parts.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-3499) [classlib][pack200] Ongoing implementation of pack200

Posted by "Alex Blewitt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Blewitt updated HARMONY-3499:
----------------------------------

    Attachment: 2-CPRef.diff

This used to be called 'CPFieldRef' in the same directory (trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode) but I renamed it to CPRef and made a few changes. I haven't got a clue whether this will apply properly or not -- my guess is not -- but you could try renaming CPFieldRef to CPRef and then applying this diff.

If not, I've attached the same file in the 2-newfiles.zip which you can apply instead.

> [classlib][pack200] Ongoing implementation of pack200
> -----------------------------------------------------
>
>                 Key: HARMONY-3499
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3499
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Alex Blewitt
>            Priority: Minor
>         Attachments: 1-newfiles.zip, 2-CPRef.diff
>
>
> This adds support for a few new bits and pieces. They aren't all related in this suite of patches, but I want to get them in before I submit changes for some of the larger parts.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HARMONY-3499) [classlib][pack200] Ongoing implementation of pack200

Posted by "Alexei Zakharov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexei Zakharov resolved HARMONY-3499.
--------------------------------------

    Resolution: Fixed

Thanks Alex. I did the following:
1. Unpacked 1-newfiles.zip to classlib/trunk/modules/pack200
2. Unpacked 2-CPRefs.zip
3. Unpacked 3-newfiles.zip
4. Applied bytecode.diff
Hope the sequence was correct :) The result was committed at the revision 522864. Please check.

> [classlib][pack200] Ongoing implementation of pack200
> -----------------------------------------------------
>
>                 Key: HARMONY-3499
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3499
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Alex Blewitt
>         Assigned To: Alexei Zakharov
>            Priority: Minor
>         Attachments: 1-newfiles.zip, 2-CPRef.diff, 2-CPRefs.zip, 3-newfiles.zip, bytecode.diff
>
>
> This adds support for a few new bits and pieces. They aren't all related in this suite of patches, but I want to get them in before I submit changes for some of the larger parts.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-3499) [classlib][pack200] Ongoing implementation of pack200

Posted by "Alex Blewitt (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-3499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12484637 ] 

Alex Blewitt commented on HARMONY-3499:
---------------------------------------

Looks good to me. I would strongly recommend that people don't do svn moves (or refactoring in Eclipse) if your only means of sending changes is through diffs; Eclipse (and indeed, the command line) got thoroughly confused whilst trying to apply the changes I'd made, and I only renamed one class ... much hacking in the .svn files was needed to get it to update properly.

> [classlib][pack200] Ongoing implementation of pack200
> -----------------------------------------------------
>
>                 Key: HARMONY-3499
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3499
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Alex Blewitt
>         Assigned To: Alexei Zakharov
>            Priority: Minor
>         Attachments: 1-newfiles.zip, 2-CPRef.diff, 2-CPRefs.zip, 3-newfiles.zip, bytecode.diff
>
>
> This adds support for a few new bits and pieces. They aren't all related in this suite of patches, but I want to get them in before I submit changes for some of the larger parts.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-3499) [classlib][pack200] Ongoing implementation of pack200

Posted by "Alex Blewitt (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-3499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12484615 ] 

Alex Blewitt commented on HARMONY-3499:
---------------------------------------

If there's no compile errors (or test failures), then it probably worked :-) I'll check and let you know.

> [classlib][pack200] Ongoing implementation of pack200
> -----------------------------------------------------
>
>                 Key: HARMONY-3499
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3499
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Alex Blewitt
>         Assigned To: Alexei Zakharov
>            Priority: Minor
>         Attachments: 1-newfiles.zip, 2-CPRef.diff, 2-CPRefs.zip, 3-newfiles.zip, bytecode.diff
>
>
> This adds support for a few new bits and pieces. They aren't all related in this suite of patches, but I want to get them in before I submit changes for some of the larger parts.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-3499) [classlib][pack200] Ongoing implementation of pack200

Posted by "Alex Blewitt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Blewitt updated HARMONY-3499:
----------------------------------

    Attachment: bytecode.diff

A few minor fixes to the bytecode package

> [classlib][pack200] Ongoing implementation of pack200
> -----------------------------------------------------
>
>                 Key: HARMONY-3499
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3499
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Alex Blewitt
>            Priority: Minor
>         Attachments: 1-newfiles.zip, 2-CPRef.diff, 2-CPRefs.zip, 3-newfiles.zip, bytecode.diff
>
>
> This adds support for a few new bits and pieces. They aren't all related in this suite of patches, but I want to get them in before I submit changes for some of the larger parts.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-3499) [classlib][pack200] Ongoing implementation of pack200

Posted by "Alexei Zakharov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-3499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12484739 ] 

Alexei Zakharov commented on HARMONY-3499:
------------------------------------------

Well, some people send scripts with "svn move" along with patch files if they want to rename or delete something. But I think that zip files are also ok.

> [classlib][pack200] Ongoing implementation of pack200
> -----------------------------------------------------
>
>                 Key: HARMONY-3499
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3499
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Alex Blewitt
>         Assigned To: Alexei Zakharov
>            Priority: Minor
>         Attachments: 1-newfiles.zip, 2-CPRef.diff, 2-CPRefs.zip, 3-newfiles.zip, bytecode.diff
>
>
> This adds support for a few new bits and pieces. They aren't all related in this suite of patches, but I want to get them in before I submit changes for some of the larger parts.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (HARMONY-3499) [classlib][pack200] Ongoing implementation of pack200

Posted by "Alexei Zakharov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexei Zakharov closed HARMONY-3499.
------------------------------------


Closing the JIRA.

> [classlib][pack200] Ongoing implementation of pack200
> -----------------------------------------------------
>
>                 Key: HARMONY-3499
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3499
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Alex Blewitt
>         Assigned To: Alexei Zakharov
>            Priority: Minor
>         Attachments: 1-newfiles.zip, 2-CPRef.diff, 2-CPRefs.zip, 3-newfiles.zip, bytecode.diff
>
>
> This adds support for a few new bits and pieces. They aren't all related in this suite of patches, but I want to get them in before I submit changes for some of the larger parts.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HARMONY-3499) [classlib][pack200] Ongoing implementation of pack200

Posted by "Alexei Zakharov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexei Zakharov reassigned HARMONY-3499:
----------------------------------------

    Assignee: Alexei Zakharov

> [classlib][pack200] Ongoing implementation of pack200
> -----------------------------------------------------
>
>                 Key: HARMONY-3499
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3499
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Alex Blewitt
>         Assigned To: Alexei Zakharov
>            Priority: Minor
>         Attachments: 1-newfiles.zip, 2-CPRef.diff, 2-CPRefs.zip, 3-newfiles.zip, bytecode.diff
>
>
> This adds support for a few new bits and pieces. They aren't all related in this suite of patches, but I want to get them in before I submit changes for some of the larger parts.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-3499) [classlib][pack200] Ongoing implementation of pack200

Posted by "Alex Blewitt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Blewitt updated HARMONY-3499:
----------------------------------

    Attachment: 1-newfiles.zip

Here are some newly created files to be added into trunk/modules/pack200

src/main/java/org/apache/harmony/pack200/SegmentUtils.java
src/main/java/org/apache/harmony/pack200/IMatcher.java
src/test/java/org/apache/harmony/pack200/tests/SegmentUtilsTest.java


> [classlib][pack200] Ongoing implementation of pack200
> -----------------------------------------------------
>
>                 Key: HARMONY-3499
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3499
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Alex Blewitt
>            Priority: Minor
>         Attachments: 1-newfiles.zip
>
>
> This adds support for a few new bits and pieces. They aren't all related in this suite of patches, but I want to get them in before I submit changes for some of the larger parts.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-3499) [classlib][pack200] Ongoing implementation of pack200

Posted by "Alex Blewitt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Blewitt updated HARMONY-3499:
----------------------------------

    Attachment: 2-CPRefs.zip

This also supplies the diff with 2-CPRef.diff that's attached. It also includes:

src/main/java/org/apache/harmony/pack200/bytecode/CPFieldRef.java
src/main/java/org/apache/harmony/pack200/bytecode/CPInterfaceMethodRef.java
src/main/java/org/apache/harmony/pack200/bytecode/CPMethodRef.java
src/main/java/org/apache/harmony/pack200/bytecode/CPRef.java
src/main/java/org/apache/harmony/pack200/bytecode/ExceptionTableEntry.java

the remainder of which are new files. I think this requires the 1-newfiles.zip to be applied (but maybe not)

> [classlib][pack200] Ongoing implementation of pack200
> -----------------------------------------------------
>
>                 Key: HARMONY-3499
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3499
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Alex Blewitt
>            Priority: Minor
>         Attachments: 1-newfiles.zip, 2-CPRef.diff, 2-CPRefs.zip, 3-newfiles.zip
>
>
> This adds support for a few new bits and pieces. They aren't all related in this suite of patches, but I want to get them in before I submit changes for some of the larger parts.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.