You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2012/01/08 17:34:49 UTC

DO NOT REPLY [Bug 52438] New: [PATCH] Patch to CellDateFormatter for formats with hours and minutes but not seconds

https://issues.apache.org/bugzilla/show_bug.cgi?id=52438

             Bug #: 52438
           Summary: [PATCH] Patch to CellDateFormatter for formats with
                    hours and minutes but not seconds
           Product: POI
           Version: unspecified
          Platform: PC
            Status: NEW
          Severity: normal
          Priority: P2
         Component: POI Overall
        AssignedTo: dev@poi.apache.org
        ReportedBy: steve.vysny@gmail.com
    Classification: Unclassified


Created attachment 28123
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=28123
Patch svn diff

Attached patch resolves issue in CellDataFormatter that causes date-time values
to be formatted incorrectly for a format with hours and minutes but not seconds
(e.g. "h:m").

New test case added to DateFormatTests.xlsx (sheet 'Tests', row 42).

Additional change to DateFormatTests.xlsx: on sheet 'Flags', deleted value of
Categories flag and changed value of AllColors flag to True, so that all tests
in the workbook are run.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


DO NOT REPLY [Bug 52438] [PATCH] Patch to CellDateFormatter for formats with hours and minutes but not seconds

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52438

Steve Vysny <st...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Platform|PC                          |All
            Version|unspecified                 |3.8-dev
         OS/Version|                            |All

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


DO NOT REPLY [Bug 52438] [PATCH] Patch to CellDateFormatter for formats with hours and minutes but not seconds

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52438

Nick Burch <ni...@alfresco.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #2 from Nick Burch <ni...@alfresco.com> 2012-01-09 18:22:43 UTC ---
Thanks, patch applied in r1229281.

(As an aside, this code looks to duplicate some of the things in DataFormatter,
so long term we should probably try to merge the logic of the two where
possible)

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


DO NOT REPLY [Bug 52438] [PATCH] Patch to CellDateFormatter for formats with hours and minutes but not seconds

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52438

--- Comment #1 from Steve Vysny <st...@gmail.com> 2012-01-08 16:39:17 UTC ---
Created attachment 28124
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=28124
DateFormatTests.xlsx with new test

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org