You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/10 05:19:01 UTC

[GitHub] [spark] cloud-fan commented on pull request #31427: [SPARK-34209][SQL] Delegate table name validation to the session catalog

cloud-fan commented on pull request #31427:
URL: https://github.com/apache/spark/pull/31427#issuecomment-776449191


   @holdenk Can we make sure PRs are merged with at least one approval from committers? And also please enrich the PR description a bit more: I don't see where the delegation happens. This PR simply removes the name check in `SessionCatalogAndIdentifier`.
   
   I'm not going to revert it as the behavior change seems only to happen in the error message. But I think we should explain clearly how we handle invalid identifiers now. There are two different errors: `Unsupported function name ...` and `Table or view not found ...`, and I'm curious about what leads to this difference.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org