You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/06/06 06:47:55 UTC

[GitHub] [airflow] uranusjr commented on a diff in pull request #24117: Don't crash scheduler if exec config has old k8s objects

uranusjr commented on code in PR #24117:
URL: https://github.com/apache/airflow/pull/24117#discussion_r889867966


##########
airflow/models/taskinstance.py:
##########
@@ -400,6 +400,13 @@ def key(self) -> "TaskInstanceKey":
         return self
 
 
+def executor_config_comparator(x, y):
+    try:
+        return x == y
+    except AttributeError:

Review Comment:
   Instead of catching AttributeError here (which is confusing), can this failover happen in `__eq__` instead?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org