You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu> on 2022/08/15 23:51:21 UTC
Change in asterixdb[master]: WIP: multiple occurrences of same variable in join condition
From Ali Alsuliman <al...@gmail.com>:
Ali Alsuliman has uploaded this change for review. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17123 )
Change subject: WIP: multiple occurrences of same variable in join condition
......................................................................
WIP: multiple occurrences of same variable in join condition
Change-Id: I3e0e8377e851b3167a29333f18a8df9ef57194ce
---
M hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/util/JoinUtils.java
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/23/17123/1
diff --git a/hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/util/JoinUtils.java b/hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/util/JoinUtils.java
index 1ac7614..dcf7fe4 100644
--- a/hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/util/JoinUtils.java
+++ b/hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/util/JoinUtils.java
@@ -165,17 +165,17 @@
return false;
}
LogicalVariable var1 = ((VariableReferenceExpression) opLeft).getVariableReference();
- if (inLeftAll.contains(var1) && !outLeftFields.contains(var1)) {
+ if (inLeftAll.contains(var1)) {
outLeftFields.add(var1);
- } else if (inRightAll.contains(var1) && !outRightFields.contains(var1)) {
+ } else if (inRightAll.contains(var1)) {
outRightFields.add(var1);
} else {
return false;
}
LogicalVariable var2 = ((VariableReferenceExpression) opRight).getVariableReference();
- if (inLeftAll.contains(var2) && !outLeftFields.contains(var2)) {
+ if (inLeftAll.contains(var2)) {
outLeftFields.add(var2);
- } else if (inRightAll.contains(var2) && !outRightFields.contains(var2)) {
+ } else if (inRightAll.contains(var2)) {
outRightFields.add(var2);
} else {
return false;
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17123
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I3e0e8377e851b3167a29333f18a8df9ef57194ce
Gerrit-Change-Number: 17123
Gerrit-PatchSet: 1
Gerrit-Owner: Ali Alsuliman <al...@gmail.com>
Gerrit-MessageType: newchange
Change in asterixdb[master]: WIP: multiple occurrences of same variable in join condition
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
Anon. E. Moose #1000171 has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17123 )
Change subject: WIP: multiple occurrences of same variable in join condition
......................................................................
Patch Set 1: Contrib-2
Analytics Compatibility Tests Failed
https://cbjenkins.page.link/MAf4qoy9r3vVStvMA : UNSTABLE
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17123
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I3e0e8377e851b3167a29333f18a8df9ef57194ce
Gerrit-Change-Number: 17123
Gerrit-PatchSet: 1
Gerrit-Owner: Ali Alsuliman <al...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Tue, 16 Aug 2022 02:00:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Change in asterixdb[master]: WIP: multiple occurrences of same variable in join condition
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
From Ali Alsuliman <al...@gmail.com>:
Ali Alsuliman has uploaded this change for review. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17123 )
Change subject: WIP: multiple occurrences of same variable in join condition
......................................................................
WIP: multiple occurrences of same variable in join condition
Change-Id: I3e0e8377e851b3167a29333f18a8df9ef57194ce
---
M hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/util/JoinUtils.java
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/23/17123/1
diff --git a/hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/util/JoinUtils.java b/hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/util/JoinUtils.java
index 1ac7614..dcf7fe4 100644
--- a/hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/util/JoinUtils.java
+++ b/hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/util/JoinUtils.java
@@ -165,17 +165,17 @@
return false;
}
LogicalVariable var1 = ((VariableReferenceExpression) opLeft).getVariableReference();
- if (inLeftAll.contains(var1) && !outLeftFields.contains(var1)) {
+ if (inLeftAll.contains(var1)) {
outLeftFields.add(var1);
- } else if (inRightAll.contains(var1) && !outRightFields.contains(var1)) {
+ } else if (inRightAll.contains(var1)) {
outRightFields.add(var1);
} else {
return false;
}
LogicalVariable var2 = ((VariableReferenceExpression) opRight).getVariableReference();
- if (inLeftAll.contains(var2) && !outLeftFields.contains(var2)) {
+ if (inLeftAll.contains(var2)) {
outLeftFields.add(var2);
- } else if (inRightAll.contains(var2) && !outRightFields.contains(var2)) {
+ } else if (inRightAll.contains(var2)) {
outRightFields.add(var2);
} else {
return false;
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17123
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I3e0e8377e851b3167a29333f18a8df9ef57194ce
Gerrit-Change-Number: 17123
Gerrit-PatchSet: 1
Gerrit-Owner: Ali Alsuliman <al...@gmail.com>
Gerrit-MessageType: newchange
Change in asterixdb[master]: WIP: multiple occurrences of same variable in join condition
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
Anon. E. Moose #1000171 has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17123 )
Change subject: WIP: multiple occurrences of same variable in join condition
......................................................................
Patch Set 2:
Analytics Compatibility Compilation Successful
: SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17123
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I3e0e8377e851b3167a29333f18a8df9ef57194ce
Gerrit-Change-Number: 17123
Gerrit-PatchSet: 2
Gerrit-Owner: Ali Alsuliman <al...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Fri, 23 Sep 2022 21:58:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Change in asterixdb[master]: WIP: multiple occurrences of same variable in join condition
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
From Ali Alsuliman <al...@gmail.com>:
Ali Alsuliman has abandoned this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17123 )
Change subject: WIP: multiple occurrences of same variable in join condition
......................................................................
Abandoned
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17123
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I3e0e8377e851b3167a29333f18a8df9ef57194ce
Gerrit-Change-Number: 17123
Gerrit-PatchSet: 2
Gerrit-Owner: Ali Alsuliman <al...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-MessageType: abandon
Change in asterixdb[master]: WIP: multiple occurrences of same variable in join condition
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
From Ali Alsuliman <al...@gmail.com>:
Hello Jenkins, Anon. E. Moose #1000171,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17123
to look at the new patch set (#2).
Change subject: WIP: multiple occurrences of same variable in join condition
......................................................................
WIP: multiple occurrences of same variable in join condition
Change-Id: I3e0e8377e851b3167a29333f18a8df9ef57194ce
---
M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/AbstractHashJoinPOperator.java
M hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/util/JoinUtils.java
M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/properties/IPartitioningRequirementsCoordinator.java
3 files changed, 71 insertions(+), 42 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/23/17123/2
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17123
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I3e0e8377e851b3167a29333f18a8df9ef57194ce
Gerrit-Change-Number: 17123
Gerrit-PatchSet: 2
Gerrit-Owner: Ali Alsuliman <al...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-MessageType: newpatchset
Change in asterixdb[master]: WIP: multiple occurrences of same variable in join condition
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
From Jenkins <je...@fulliautomatix.ics.uci.edu>:
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17123 )
Change subject: WIP: multiple occurrences of same variable in join condition
......................................................................
Patch Set 1: Contrib+1
Graphix Compatibility Tests Successful
https://asterix-jenkins.ics.uci.edu/job/graphix-compat/214/ : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17123
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I3e0e8377e851b3167a29333f18a8df9ef57194ce
Gerrit-Change-Number: 17123
Gerrit-PatchSet: 1
Gerrit-Owner: Ali Alsuliman <al...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-CC: Anon. E. Moose #1000171
Gerrit-Comment-Date: Tue, 16 Aug 2022 00:08:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Change in asterixdb[master]: WIP: multiple occurrences of same variable in join condition
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
Anon. E. Moose #1000171 has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17123 )
Change subject: WIP: multiple occurrences of same variable in join condition
......................................................................
Patch Set 2: Contrib+1
Analytics Compatibility Tests Successful
: SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17123
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I3e0e8377e851b3167a29333f18a8df9ef57194ce
Gerrit-Change-Number: 17123
Gerrit-PatchSet: 2
Gerrit-Owner: Ali Alsuliman <al...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Sat, 24 Sep 2022 00:03:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Change in asterixdb[master]: WIP: multiple occurrences of same variable in join condition
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
Anon. E. Moose #1000171 has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17123 )
Change subject: WIP: multiple occurrences of same variable in join condition
......................................................................
Patch Set 1:
Analytics Compatibility Compilation Successful
https://cbjenkins.page.link/dQEk1QpXQfQ8ggVw7 : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17123
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I3e0e8377e851b3167a29333f18a8df9ef57194ce
Gerrit-Change-Number: 17123
Gerrit-PatchSet: 1
Gerrit-Owner: Ali Alsuliman <al...@gmail.com>
Gerrit-CC: Anon. E. Moose #1000171
Gerrit-CC: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Tue, 16 Aug 2022 00:00:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Change in asterixdb[master]: WIP: multiple occurrences of same variable in join condition
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
From Jenkins <je...@fulliautomatix.ics.uci.edu>:
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17123 )
Change subject: WIP: multiple occurrences of same variable in join condition
......................................................................
Patch Set 1:
Graphix Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/graphix-compat/214/
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17123
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I3e0e8377e851b3167a29333f18a8df9ef57194ce
Gerrit-Change-Number: 17123
Gerrit-PatchSet: 1
Gerrit-Owner: Ali Alsuliman <al...@gmail.com>
Gerrit-CC: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Mon, 15 Aug 2022 23:53:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment