You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@allura.apache.org by Cory Johns <ma...@users.sf.net> on 2013/10/31 19:27:49 UTC

[allura:tickets] #6821 Change hg browser to get "last commit" info from hg instead of mongo



---

** [tickets:#6821] Change hg browser to get "last commit" info from hg instead of mongo**

**Status:** open
**Labels:** performance indexless 
**Created:** Thu Oct 31, 2013 06:27 PM UTC by Cory Johns
**Last Updated:** Thu Oct 31, 2013 06:27 PM UTC
**Owner:** nobody

[#6686] changed git to pull last commit info directly from the SCM instead of mongo, and SVN already did the same.  Now we just need to change the Mercurial browser to do the same.


---

Sent from sourceforge.net because allura-dev@incubator.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

[allura:tickets] #6821 Change hg browser to get "last commit" info from hg instead of mongo

Posted by Cory Johns <ma...@users.sf.net>.
Updated:
`allura:cj/6821`
`forgehg:cj/6821`


---

** [tickets:#6821] Change hg browser to get "last commit" info from hg instead of mongo**

**Status:** code-review
**Labels:** performance indexless 
**Created:** Thu Oct 31, 2013 06:27 PM UTC by Cory Johns
**Last Updated:** Tue Dec 17, 2013 01:20 AM UTC
**Owner:** Cory Johns

[#6686] changed git to pull last commit info directly from the SCM instead of mongo, and SVN already did the same.  Now we just need to change the Mercurial browser to do the same.


---

Sent from sourceforge.net because allura-dev@incubator.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

[allura:tickets] #6821 Change hg browser to get "last commit" info from hg instead of mongo

Posted by Dave Brondsema <br...@users.sf.net>.
RepositoryImplementation now has two `last_commit_ids` methods

The new method should have a docstring explaining how a specific SCM could implement just the `_get_last_commit` method

`forgegit.tests.model.test_repository:TestGitImplementation.test_last_commit_ids` is now failing


---

** [tickets:#6821] Change hg browser to get "last commit" info from hg instead of mongo**

**Status:** in-progress
**Labels:** performance indexless 
**Created:** Thu Oct 31, 2013 06:27 PM UTC by Cory Johns
**Last Updated:** Mon Dec 16, 2013 08:45 PM UTC
**Owner:** Cory Johns

[#6686] changed git to pull last commit info directly from the SCM instead of mongo, and SVN already did the same.  Now we just need to change the Mercurial browser to do the same.


---

Sent from sourceforge.net because allura-dev@incubator.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

[allura:tickets] #6821 Change hg browser to get "last commit" info from hg instead of mongo

Posted by Dave Brondsema <br...@users.sf.net>.
In the test, it'd be better if it was clear why the error handling would be invoked.

It'd be better to timing out rather than hanging, when something does goes wrong in the threads and isn't caught.

There's quite a bit of logic overlap between hg & git's `last_commit_ids`: http://pastie.org/8547562  Could that be refactored and shared?

Git's implementation specifies no_merges=True, we should be consistent with hg.  `hg log` takes a `--no-merges` param; can we do this with `cmdutil.walkchangerevs` though?  I prefer no merges, but showing merges on both would be ok too.  It also seems that merge commits aren't displayed in log view (either via allura or commandline, which I don't really understand).    Example: merge commit ada01d on /NEWS.txt in the SF 'coils' repo.  Which makes it confusing when you see the merge commit on the tree view but not the history view.



---

** [tickets:#6821] Change hg browser to get "last commit" info from hg instead of mongo**

**Status:** in-progress
**Labels:** performance indexless 
**Created:** Thu Oct 31, 2013 06:27 PM UTC by Cory Johns
**Last Updated:** Thu Dec 12, 2013 03:38 PM UTC
**Owner:** Cory Johns

[#6686] changed git to pull last commit info directly from the SCM instead of mongo, and SVN already did the same.  Now we just need to change the Mercurial browser to do the same.


---

Sent from sourceforge.net because allura-dev@incubator.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

[allura:tickets] #6821 Change hg browser to get "last commit" info from hg instead of mongo

Posted by Dave Brondsema <br...@users.sf.net>.
- **QA**: Dave Brondsema



---

** [tickets:#6821] Change hg browser to get "last commit" info from hg instead of mongo**

**Status:** code-review
**Labels:** performance indexless 
**Created:** Thu Oct 31, 2013 06:27 PM UTC by Cory Johns
**Last Updated:** Fri Dec 06, 2013 04:28 PM UTC
**Owner:** Cory Johns

[#6686] changed git to pull last commit info directly from the SCM instead of mongo, and SVN already did the same.  Now we just need to change the Mercurial browser to do the same.


---

Sent from sourceforge.net because allura-dev@incubator.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

[allura:tickets] #6821 Change hg browser to get "last commit" info from hg instead of mongo

Posted by Cory Johns <ma...@users.sf.net>.
Updated:
`allura:cj/6821`

Ugh.  The behavior of `git log` with respect to merge commits appears to contradict the detailed explanation under [History Simplication](https://www.kernel.org/pub/software/scm/git/docs/git-log.html#_history_simplification) (specifically the bits about the default mode and `--dense`).  Apparently, git will sometimes return a merge commit as having modified a given path, even though it doesn't list it as modified in the output from the `--name-only` option.


---

** [tickets:#6821] Change hg browser to get "last commit" info from hg instead of mongo**

**Status:** code-review
**Labels:** performance indexless 
**Created:** Thu Oct 31, 2013 06:27 PM UTC by Cory Johns
**Last Updated:** Mon Dec 16, 2013 10:47 PM UTC
**Owner:** Cory Johns

[#6686] changed git to pull last commit info directly from the SCM instead of mongo, and SVN already did the same.  Now we just need to change the Mercurial browser to do the same.


---

Sent from sourceforge.net because allura-dev@incubator.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

[allura:tickets] #6821 Change hg browser to get "last commit" info from hg instead of mongo

Posted by Cory Johns <ma...@users.sf.net>.
- **status**: in-progress --> code-review



---

** [tickets:#6821] Change hg browser to get "last commit" info from hg instead of mongo**

**Status:** code-review
**Labels:** performance indexless 
**Created:** Thu Oct 31, 2013 06:27 PM UTC by Cory Johns
**Last Updated:** Wed Dec 18, 2013 05:40 PM UTC
**Owner:** Cory Johns

[#6686] changed git to pull last commit info directly from the SCM instead of mongo, and SVN already did the same.  Now we just need to change the Mercurial browser to do the same.


---

Sent from sourceforge.net because allura-dev@incubator.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

[allura:tickets] #6821 Change hg browser to get "last commit" info from hg instead of mongo

Posted by Dave Brondsema <br...@users.sf.net>.
A number of allura.tests.model.test_repo:TestLastCommit test failures, mostly due to `get_changes` method


---

** [tickets:#6821] Change hg browser to get "last commit" info from hg instead of mongo**

**Status:** in-progress
**Labels:** performance indexless 
**Created:** Thu Oct 31, 2013 06:27 PM UTC by Cory Johns
**Last Updated:** Tue Dec 17, 2013 09:54 PM UTC
**Owner:** Cory Johns

[#6686] changed git to pull last commit info directly from the SCM instead of mongo, and SVN already did the same.  Now we just need to change the Mercurial browser to do the same.


---

Sent from sourceforge.net because allura-dev@incubator.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

[allura:tickets] #6821 Change hg browser to get "last commit" info from hg instead of mongo

Posted by Cory Johns <ma...@users.sf.net>.
`forgehg:cj/6821`
`allura:cj/6821`

Found an issue where errors in the thread workers could potentially block the request indefinitely.  Fixed in both Hg and Git.


---

** [tickets:#6821] Change hg browser to get "last commit" info from hg instead of mongo**

**Status:** code-review
**Labels:** performance indexless 
**Created:** Thu Oct 31, 2013 06:27 PM UTC by Cory Johns
**Last Updated:** Wed Dec 04, 2013 10:27 PM UTC
**Owner:** Cory Johns

[#6686] changed git to pull last commit info directly from the SCM instead of mongo, and SVN already did the same.  Now we just need to change the Mercurial browser to do the same.


---

Sent from sourceforge.net because allura-dev@incubator.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

[allura:tickets] #6821 Change hg browser to get "last commit" info from hg instead of mongo

Posted by Dave Brondsema <br...@users.sf.net>.
- **status**: code-review --> closed



---

** [tickets:#6821] Change hg browser to get "last commit" info from hg instead of mongo**

**Status:** closed
**Labels:** performance indexless 
**Created:** Thu Oct 31, 2013 06:27 PM UTC by Cory Johns
**Last Updated:** Wed Dec 18, 2013 07:11 PM UTC
**Owner:** Cory Johns

[#6686] changed git to pull last commit info directly from the SCM instead of mongo, and SVN already did the same.  Now we just need to change the Mercurial browser to do the same.


---

Sent from sourceforge.net because allura-dev@incubator.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

[allura:tickets] #6821 Change hg browser to get "last commit" info from hg instead of mongo

Posted by Dave Brondsema <br...@users.sf.net>.
- **Size**:  --> 2



---

** [tickets:#6821] Change hg browser to get "last commit" info from hg instead of mongo**

**Status:** open
**Labels:** performance indexless 
**Created:** Thu Oct 31, 2013 06:27 PM UTC by Cory Johns
**Last Updated:** Fri Nov 15, 2013 06:54 PM UTC
**Owner:** nobody

[#6686] changed git to pull last commit info directly from the SCM instead of mongo, and SVN already did the same.  Now we just need to change the Mercurial browser to do the same.


---

Sent from sourceforge.net because allura-dev@incubator.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

[allura:tickets] #6821 Change hg browser to get "last commit" info from hg instead of mongo

Posted by Cory Johns <ma...@users.sf.net>.
`allura:cj/6821`


---

** [tickets:#6821] Change hg browser to get "last commit" info from hg instead of mongo**

**Status:** code-review
**Labels:** performance indexless 
**Created:** Thu Oct 31, 2013 06:27 PM UTC by Cory Johns
**Last Updated:** Wed Dec 18, 2013 05:40 PM UTC
**Owner:** Cory Johns

[#6686] changed git to pull last commit info directly from the SCM instead of mongo, and SVN already did the same.  Now we just need to change the Mercurial browser to do the same.


---

Sent from sourceforge.net because allura-dev@incubator.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

[allura:tickets] #6821 Change hg browser to get "last commit" info from hg instead of mongo

Posted by Cory Johns <ma...@users.sf.net>.
- **status**: in-progress --> code-review



---

** [tickets:#6821] Change hg browser to get "last commit" info from hg instead of mongo**

**Status:** code-review
**Labels:** performance indexless 
**Created:** Thu Oct 31, 2013 06:27 PM UTC by Cory Johns
**Last Updated:** Fri Dec 13, 2013 06:21 PM UTC
**Owner:** Cory Johns

[#6686] changed git to pull last commit info directly from the SCM instead of mongo, and SVN already did the same.  Now we just need to change the Mercurial browser to do the same.


---

Sent from sourceforge.net because allura-dev@incubator.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

[allura:tickets] #6821 Change hg browser to get "last commit" info from hg instead of mongo

Posted by Cory Johns <ma...@users.sf.net>.
- **status**: in-progress --> code-review



---

** [tickets:#6821] Change hg browser to get "last commit" info from hg instead of mongo**

**Status:** code-review
**Labels:** performance indexless 
**Created:** Thu Oct 31, 2013 06:27 PM UTC by Cory Johns
**Last Updated:** Mon Dec 16, 2013 10:47 PM UTC
**Owner:** Cory Johns

[#6686] changed git to pull last commit info directly from the SCM instead of mongo, and SVN already did the same.  Now we just need to change the Mercurial browser to do the same.


---

Sent from sourceforge.net because allura-dev@incubator.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

[allura:tickets] #6821 Change hg browser to get "last commit" info from hg instead of mongo

Posted by Cory Johns <ma...@users.sf.net>.
Rebased and force-pushed to:
`allura:cj/6821`
`forgehg:cj/6821`

Removed the merge commit filter from git because: 1) that was easier, and 2) it more closes matches what you would see from `git log` on the command line (and also on the history / log view on the web).


---

** [tickets:#6821] Change hg browser to get "last commit" info from hg instead of mongo**

**Status:** code-review
**Labels:** performance indexless 
**Created:** Thu Oct 31, 2013 06:27 PM UTC by Cory Johns
**Last Updated:** Fri Dec 13, 2013 06:21 PM UTC
**Owner:** Cory Johns

[#6686] changed git to pull last commit info directly from the SCM instead of mongo, and SVN already did the same.  Now we just need to change the Mercurial browser to do the same.


---

Sent from sourceforge.net because allura-dev@incubator.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

[allura:tickets] #6821 Change hg browser to get "last commit" info from hg instead of mongo

Posted by Cory Johns <ma...@users.sf.net>.
- **status**: open --> in-progress
- **assigned_to**: Cory Johns



---

** [tickets:#6821] Change hg browser to get "last commit" info from hg instead of mongo**

**Status:** in-progress
**Labels:** performance indexless 
**Created:** Thu Oct 31, 2013 06:27 PM UTC by Cory Johns
**Last Updated:** Tue Dec 03, 2013 06:06 PM UTC
**Owner:** Cory Johns

[#6686] changed git to pull last commit info directly from the SCM instead of mongo, and SVN already did the same.  Now we just need to change the Mercurial browser to do the same.


---

Sent from sourceforge.net because allura-dev@incubator.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

[allura:tickets] #6821 Change hg browser to get "last commit" info from hg instead of mongo

Posted by Dave Brondsema <br...@users.sf.net>.
- **status**: code-review --> in-progress



---

** [tickets:#6821] Change hg browser to get "last commit" info from hg instead of mongo**

**Status:** in-progress
**Labels:** performance indexless 
**Created:** Thu Oct 31, 2013 06:27 PM UTC by Cory Johns
**Last Updated:** Mon Dec 16, 2013 08:45 PM UTC
**Owner:** Cory Johns

[#6686] changed git to pull last commit info directly from the SCM instead of mongo, and SVN already did the same.  Now we just need to change the Mercurial browser to do the same.


---

Sent from sourceforge.net because allura-dev@incubator.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

[allura:tickets] #6821 Change hg browser to get "last commit" info from hg instead of mongo

Posted by Dave Brondsema <br...@users.sf.net>.
- **status**: code-review --> in-progress



---

** [tickets:#6821] Change hg browser to get "last commit" info from hg instead of mongo**

**Status:** in-progress
**Labels:** performance indexless 
**Created:** Thu Oct 31, 2013 06:27 PM UTC by Cory Johns
**Last Updated:** Thu Dec 12, 2013 03:38 PM UTC
**Owner:** Cory Johns

[#6686] changed git to pull last commit info directly from the SCM instead of mongo, and SVN already did the same.  Now we just need to change the Mercurial browser to do the same.


---

Sent from sourceforge.net because allura-dev@incubator.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

[allura:tickets] #6821 Change hg browser to get "last commit" info from hg instead of mongo

Posted by Dave Brondsema <br...@users.sf.net>.
- **status**: code-review --> in-progress



---

** [tickets:#6821] Change hg browser to get "last commit" info from hg instead of mongo**

**Status:** in-progress
**Labels:** performance indexless 
**Created:** Thu Oct 31, 2013 06:27 PM UTC by Cory Johns
**Last Updated:** Tue Dec 17, 2013 09:54 PM UTC
**Owner:** Cory Johns

[#6686] changed git to pull last commit info directly from the SCM instead of mongo, and SVN already did the same.  Now we just need to change the Mercurial browser to do the same.


---

Sent from sourceforge.net because allura-dev@incubator.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

[allura:tickets] #6821 Change hg browser to get "last commit" info from hg instead of mongo

Posted by Cory Johns <ma...@users.sf.net>.
- **status**: in-progress --> code-review



---

** [tickets:#6821] Change hg browser to get "last commit" info from hg instead of mongo**

**Status:** code-review
**Labels:** performance indexless 
**Created:** Thu Oct 31, 2013 06:27 PM UTC by Cory Johns
**Last Updated:** Wed Dec 04, 2013 10:27 PM UTC
**Owner:** Cory Johns

[#6686] changed git to pull last commit info directly from the SCM instead of mongo, and SVN already did the same.  Now we just need to change the Mercurial browser to do the same.


---

Sent from sourceforge.net because allura-dev@incubator.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.