You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@impala.apache.org by "Joe McDonnell (Jira)" <ji...@apache.org> on 2022/09/09 20:06:00 UTC
[jira] [Resolved] (IMPALA-11569) Run finalize.sh in bin/jenkins/all-tests.sh even if dataload fails
[ https://issues.apache.org/jira/browse/IMPALA-11569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joe McDonnell resolved IMPALA-11569.
------------------------------------
Fix Version/s: Impala 4.2.0
Resolution: Fixed
> Run finalize.sh in bin/jenkins/all-tests.sh even if dataload fails
> ------------------------------------------------------------------
>
> Key: IMPALA-11569
> URL: https://issues.apache.org/jira/browse/IMPALA-11569
> Project: IMPALA
> Issue Type: Improvement
> Components: Infrastructure
> Affects Versions: Impala 4.2.0
> Reporter: Joe McDonnell
> Assignee: Joe McDonnell
> Priority: Major
> Fix For: Impala 4.2.0
>
>
> bin/jenkins/all-tests.sh (used for precommit Jenkins jobs) has "set -oeu pipefail" set, so if a command fails, it will exit. Currently, it sources bin/bootstrap_development.sh, so if that fails it will not run finalize.sh.
> {noformat}
> source bin/bootstrap_development.sh
> ...
> RET_CODE=0
> if ! bin/run-all-tests.sh; then
> RET_CODE=1
> fi
> # Shutdown minicluster at the end
> testdata/bin/kill-all.sh
> bin/jenkins/finalize.sh
> exit $RET_CODE{noformat}
> finalize.sh is useful for resolving minidumps and generating JUnitXML. bootstrap_development.sh runs dataload, so Impala could crash and finalize.sh wouldn't run. We should change it so that finalize.sh runs even if dataload fails.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)