You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by jw...@apache.org on 2010/07/21 04:03:42 UTC
svn commit: r966067 - in
/myfaces/trinidad/trunk/trinidad-impl/src/main/resources/META-INF/adf/styles:
base-desktop.xss casablancaSkin.css
Author: jwaldman
Date: Wed Jul 21 02:03:42 2010
New Revision: 966067
URL: http://svn.apache.org/viewvc?rev=966067&view=rev
Log:
added a couple comments about the -icon selectors not being the right name.
Modified:
myfaces/trinidad/trunk/trinidad-impl/src/main/resources/META-INF/adf/styles/base-desktop.xss
myfaces/trinidad/trunk/trinidad-impl/src/main/resources/META-INF/adf/styles/casablancaSkin.css
Modified: myfaces/trinidad/trunk/trinidad-impl/src/main/resources/META-INF/adf/styles/base-desktop.xss
URL: http://svn.apache.org/viewvc/myfaces/trinidad/trunk/trinidad-impl/src/main/resources/META-INF/adf/styles/base-desktop.xss?rev=966067&r1=966066&r2=966067&view=diff
==============================================================================
--- myfaces/trinidad/trunk/trinidad-impl/src/main/resources/META-INF/adf/styles/base-desktop.xss (original)
+++ myfaces/trinidad/trunk/trinidad-impl/src/main/resources/META-INF/adf/styles/base-desktop.xss Wed Jul 21 02:03:42 2010
@@ -697,7 +697,8 @@
<property name="white-space">nowrap</property>
<property name="overflow">hidden</property>
</style>
-
+ <!-- The following selector should have been called ::close-icon-style, since it is a style,
+ not an Icon. It's too late to change since it is public. -->
<style selector="af|dialog::close-icon">
<includeStyle name="AFDefaultFont"/>
<includeStyle name="AFMediumFont"/>
@@ -1962,7 +1963,8 @@
<property name="white-space">nowrap</property>
<property name="overflow">hidden</property>
</style>
-
+ <!-- The following selector should have been called ::close-icon-style, since it is a style,
+ not an Icon. It's too late to change since it is public. -->
<style selector="af|panelPopup::close-icon">
<includeStyle name="AFDefaultFont"/>
<includeStyle name="AFMediumFont"/>
Modified: myfaces/trinidad/trunk/trinidad-impl/src/main/resources/META-INF/adf/styles/casablancaSkin.css
URL: http://svn.apache.org/viewvc/myfaces/trinidad/trunk/trinidad-impl/src/main/resources/META-INF/adf/styles/casablancaSkin.css?rev=966067&r1=966066&r2=966067&view=diff
==============================================================================
--- myfaces/trinidad/trunk/trinidad-impl/src/main/resources/META-INF/adf/styles/casablancaSkin.css (original)
+++ myfaces/trinidad/trunk/trinidad-impl/src/main/resources/META-INF/adf/styles/casablancaSkin.css Wed Jul 21 02:03:42 2010
@@ -1236,6 +1236,9 @@
}
/* Table icons */
/* We don't use ":alias" sufix because didn't work, probably its a bug */
+/* No, it's not a bug. Selectors that need to be generated into the CSS file should not end in
+Icon:alias or -icon. Those are considered Icon Objects and are not generated into the CSS.
+The fact that these selectors work is a bug. */
.CBTableSelectAllIcon{
-tr-rule-ref: selector(".CBIconLook:alias");
-tr-rule-ref: selector(".CBIconSelectAll:alias");