You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Mike Pawlowski <mp...@ca.ibm.com> on 2013/11/22 19:14:17 UTC

Review Request 15792: Review Request: JavaScript is not being cached in browser via ETag support when using WAS Liberty Profile

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15792/
-----------------------------------------------------------

Review request for shindig.


Bugs: SHINDIG-1957
    https://issues.apache.org/jira/browse/SHINDIG-1957


Repository: shindig


Description
-------

Patch for SHINDIG-1957. See JIRA issue for details.


Diffs
-----

  http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ETaggingHttpResponse.java 1543893 
  http://svn.apache.org/repos/asf/shindig/trunk/java/server-resources/src/main/webapp/WEB-INF/web.xml 1543893 

Diff: https://reviews.apache.org/r/15792/diff/


Testing
-------

Version: Apache Shindig 2.5.1 (i.e. Latest from trunk)
Web Containers: Apache Tomcat, WAS Liberty Profile

Used the sample common container page shipped with Shindig (i.e. /containers/commoncontainer/index.html).
See "Steps To Reproduce" in JIRA issue.


Thanks,

Mike Pawlowski


Re: Review Request 15792: Review Request: JavaScript is not being cached in browser via ETag support when using WAS Liberty Profile

Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15792/#review29320
-----------------------------------------------------------

Ship it!


Ship It!

- Ryan Baxter


On Nov. 22, 2013, 6:14 p.m., Mike Pawlowski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15792/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2013, 6:14 p.m.)
> 
> 
> Review request for shindig.
> 
> 
> Bugs: SHINDIG-1957
>     https://issues.apache.org/jira/browse/SHINDIG-1957
> 
> 
> Repository: shindig
> 
> 
> Description
> -------
> 
> Patch for SHINDIG-1957. See JIRA issue for details.
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ETaggingHttpResponse.java 1543893 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/server-resources/src/main/webapp/WEB-INF/web.xml 1543893 
> 
> Diff: https://reviews.apache.org/r/15792/diff/
> 
> 
> Testing
> -------
> 
> Version: Apache Shindig 2.5.1 (i.e. Latest from trunk)
> Web Containers: Apache Tomcat, WAS Liberty Profile
> 
> Used the sample common container page shipped with Shindig (i.e. /containers/commoncontainer/index.html).
> See "Steps To Reproduce" in JIRA issue.
> 
> 
> Thanks,
> 
> Mike Pawlowski
> 
>