You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2022/09/15 06:59:25 UTC

[GitHub] [phoenix] virajjasani commented on a diff in pull request #1500: PHOENIX-6789 Remove com.sun.istack.NotNull usage

virajjasani commented on code in PR #1500:
URL: https://github.com/apache/phoenix/pull/1500#discussion_r971600170


##########
pom.xml:
##########
@@ -506,6 +502,13 @@
                       <bannedImport>org.apache.commons.lang.**</bannedImport>
                     </bannedImports>
                   </restrictImports>
+                  <restrictImports implementation="de.skuzzle.enforcer.restrictimports.rule.RestrictImports">
+                    <includeTestCode>true</includeTestCode>
+                    <reason>Use edu.umd.cs.findbugs.annotations</reason>

Review Comment:
   > used mostly by IoC / DI stuff like Spring / Java EE
   
   Yes makes sense



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org