You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@avro.apache.org by GitBox <gi...@apache.org> on 2022/02/25 23:59:24 UTC

[GitHub] [avro] KyleSchoonover commented on pull request #1569: AVRO-3421 Added more test coverage to ArraySchema

KyleSchoonover commented on pull request #1569:
URL: https://github.com/apache/avro/pull/1569#issuecomment-1051381652


   Just wanted to call this out to @martin-g and @zcsizmadia.  Is there a reason the ArraySchema class doesn't just use the following instead of the private constructor and the static NewInstance method?
   
   `internal ArraySchema(JToken jtok, PropertyMap props, SchemaNames names, string encspace) : base(Type.Array, props)
           {
           }`
   
   With the functionality of both put into this one constructor. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org