[jira] [Comment Edited] (YARN-8880) Add configurations for pluggable plugin framework

["Weiwei Yang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-8880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678245#comment-16678245 ] 

Weiwei Yang edited comment on YARN-8880 at 11/7/18 2:52 PM:
------------------------------------------------------------

Hi [~tangzhankun]

Thanks for the patch. It looks good. Some small nits
 # "This settings" -> "setting"
 # ResourcePluginManager#initializePluggableDevicePlugins currently only has the null check. will more checks be added here? Just want to make sure initializing problems can be found as early as possible, like class type check etc.
 # TestResourcePluginManager: can we make sure mock NMs are stopped in each test cases?
 # Checkstyle issues need to be fixed

And there seems to have some unnecessary changes, e.g
{code:java}
- ((NMContext)this.getNMContext()).setResourcePluginManager(rpm);
+ ((NMContext) this.getNMContext()).setResourcePluginManager(rpm);
{code}
and
{code:java}
- metrics, diskhandler);
+ metrics, diskhandler);
{code}
thanks.


was (Author: cheersyang):
Hi [~tangzhankun]

Thanks for the patch. It looks good. Some small nits
 # "This settings" -> "setting"
 # ResourcePluginManager#initializePluggableDevicePlugins currently only has the null check. will more checks be added here? Just want to make sure initializing problems can be found as early as possible, like class type check etc.
 # TestResourcePluginManager: can we make sure mock NMs are stopped in each test cases?
 # Checkstyle issues need to be fixed

And there seems to have some unnecessary changes, e.g

{code}

- ((NMContext)this.getNMContext()).setResourcePluginManager(rpm);

+ ((NMContext) this.getNMContext()).setResourcePluginManager(rpm);

{code}

and

{code}

- metrics, diskhandler);

+ metrics, diskhandler);

{code}

thanks.

> Add configurations for pluggable plugin framework
> -------------------------------------------------
>
>                 Key: YARN-8880
>                 URL: https://issues.apache.org/jira/browse/YARN-8880
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Zhankun Tang
>            Assignee: Zhankun Tang
>            Priority: Major
>         Attachments: YARN-8880-trunk.001.patch, YARN-8880-trunk.002.patch, YARN-8880-trunk.003.patch
>
>
> Added two configurations for the pluggable device framework.
> {code:java}
> <property>
>  <name>yarn.nodemanager.pluggable-device-framework.enabled</name>
>  <value>true/false</value>
>  </property>
>  <property>
>  <name>yarn.nodemanager.pluggable-device-framework.device-classes</name>
>  <value>com.cmp1.hdw1,...</value>
>  </property>{code}
> The admin needs to know the register resource name of every plugin classes configured. And declare them in resource-types.xml.
> Please note that the count value defined in node-resource.xml will be overridden by plugin.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org