You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/02/26 18:14:27 UTC
[GitHub] [trafficcontrol] zrhoffman opened a new issue #5587: Traffic Ops no longer serves static files
zrhoffman opened a new issue #5587:
URL: https://github.com/apache/trafficcontrol/issues/5587
<!--
************ STOP!! ************
If this issue identifies a security vulnerability, DO NOT submit it! Instead, contact
the Apache Traffic Control Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://www.apache.org/security/ regarding vulnerability disclosure.
- For *SUPPORT QUESTIONS*, use the Traffic Control slack (https://s.apache.org/atc-slack)
or Traffic Control mailing lists (https://trafficcontrol.apache.org/mailing_lists).
- Before submitting, please **SEARCH GITHUB** for a similar issue or PR.
-->
## I'm submitting a ...
<!-- delete all those that don't apply -->
<!--- security vulnerability (STOP!! - see above)-->
- bug report
## Traffic Control components affected ...
<!-- delete all those that don't apply -->
- Traffic Ops
- Traffic Router
## Current behavior:
<!-- Describe how the bug manifests -->
Traffic Ops Perl included a static web server for files in the `/opt/traffic_ops/app/public` directory, but Traffic Ops (Golang) does not include this functionality (and TO Perl was removed in #5209).
For several files, Traffic Router polls a URL to update that resource. Examples:
- https://github.com/apache/trafficcontrol/blob/d0b2f8ae59a11f19afed87e18eb589d60a8a8ae0/infrastructure/cdn-in-a-box/traffic_ops_data/profiles/040-CCR_CIAB.json#L14-L16
- https://github.com/apache/trafficcontrol/blob/d0b2f8ae59a11f19afed87e18eb589d60a8a8ae0/infrastructure/cdn-in-a-box/traffic_ops_data/profiles/040-CCR_CIAB.json#L29-L31
In the case of CDN in a Box, for the first 2, we could add a static web server to CDN in a Box and serve them from that.
If we decide to use a static web server:
- The RPM spec should no longer create the `public` directory: https://github.com/apache/trafficcontrol/blob/eed246c7854f6f9aefab4b65ce6c35846460e8c9/traffic_ops/build/traffic_ops.spec#L225
- The Ansible dataset loader needs to be updated to not expect to get those files from Traffic Ops:
* https://github.com/apache/trafficcontrol/blob/eed246c7854f6f9aefab4b65ce6c35846460e8c9/infrastructure/ansible/roles/dataset_loader/defaults/main.yml#L28
* https://github.com/apache/trafficcontrol/blob/eed246c7854f6f9aefab4b65ce6c35846460e8c9/infrastructure/ansible/roles/dataset_loader/defaults/main.yml#L30
* https://github.com/apache/trafficcontrol/blob/eed246c7854f6f9aefab4b65ce6c35846460e8c9/infrastructure/ansible/roles/dataset_loader/defaults/main.yml#L32
* https://github.com/apache/trafficcontrol/blob/eed246c7854f6f9aefab4b65ce6c35846460e8c9/infrastructure/ansible/roles/dataset_loader/defaults/main.yml#L34
## Expected behavior:
<!-- Describe what the behavior would be without the bug -->
We should either let Traffic Ops continue to serve static files or agree on a different place to serve static files from.
## Minimal reproduction of the problem with instructions:
<!--
If the current behavior is a bug, please provide the *STEPS TO REPRODUCE* and
include the applicable TC version.
-->
Visit https://trafficops.infra.ciab.test/GeoLite2-City.mmdb.gz , observe 404
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
https://apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rawlinp commented on issue #5587: Traffic Ops no longer serves static files
Posted by GitBox <gi...@apache.org>.
rawlinp commented on issue #5587:
URL: https://github.com/apache/trafficcontrol/issues/5587#issuecomment-786814315
I kind of think the convenience factor isn't really necessary. It's super easy to set up a static file server -- I don't see why TO should have to provide one itself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on issue #5587: Traffic Ops no longer serves static files
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on issue #5587:
URL: https://github.com/apache/trafficcontrol/issues/5587#issuecomment-786813999
Since TR can be configured to get the files from any URL, I'd vote that we leave it out of Traffic Ops itself, and maybe just make some optional plugins that you can use to serve them. Or not, and serve them elsewhere, at your own discretion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 closed issue #5587: Traffic Ops no longer serves static files
Posted by GitBox <gi...@apache.org>.
ocket8888 closed issue #5587:
URL: https://github.com/apache/trafficcontrol/issues/5587
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org