You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/08/19 16:31:15 UTC
[GitHub] [superset] rickysaltzer opened a new pull request, #21138: fix(sql-lab): Allow User Impersonation in SQL Lab
rickysaltzer opened a new pull request, #21138:
URL: https://github.com/apache/superset/pull/21138
### SUMMARY
- Previously, when users execute an ad-hoc query through the SQL lab interface,
their username was not provided, and the `current_user` global was not available.
This resulted in the error described in #20455
- This patch provides the `DB_CONNECTION_MUTATOR` override the user executing the
ad-hoc query so that their credentials can be properly looked up.
### TESTING INSTRUCTIONS
Implement `DB_CONNECTION_MUTATOR` method to enable user impersonation when executing ad-hoc queries. Then, issue a query from the SQL-Lab page.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ x ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rickysaltzer commented on pull request #21138: fix(sql-lab): Allow User Impersonation in SQL Lab
Posted by GitBox <gi...@apache.org>.
rickysaltzer commented on PR #21138:
URL: https://github.com/apache/superset/pull/21138#issuecomment-1220871463
I mistakenly made this against master, while it should be a fix onto `1.5.1`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rickysaltzer closed pull request #21138: fix(sql-lab): Allow User Impersonation in SQL Lab
Posted by GitBox <gi...@apache.org>.
rickysaltzer closed pull request #21138: fix(sql-lab): Allow User Impersonation in SQL Lab
URL: https://github.com/apache/superset/pull/21138
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org