You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/10 12:56:54 UTC

[GitHub] [flink] godfreyhe commented on a diff in pull request #21225: [FLINK-29781][table-planner] Fix ChangelogNormalize uses wrong keys after transformation by WatermarkAssignerChangelogNormalizeTransposeRule

godfreyhe commented on code in PR #21225:
URL: https://github.com/apache/flink/pull/21225#discussion_r1019071678


##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/physical/stream/WatermarkAssignerChangelogNormalizeTransposeRule.java:
##########
@@ -359,6 +360,16 @@ private final RelNode buildTreeInOrder(
                                         inputNode,
                                         nodeAndTrait.f1.getTrait(
                                                 FlinkRelDistributionTraitDef.INSTANCE()));
+            } else if (currentNode instanceof StreamPhysicalChangelogNormalize) {

Review Comment:
   This is hard to maintain now, I create an issue to do the refactor: https://issues.apache.org/jira/browse/FLINK-29981



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org