You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Lars Kotthoff (JIRA)" <ji...@apache.org> on 2008/07/22 07:00:31 UTC

[jira] Created: (SOLR-645) Move facet tests into own class

Move facet tests into own class
-------------------------------

                 Key: SOLR-645
                 URL: https://issues.apache.org/jira/browse/SOLR-645
             Project: Solr
          Issue Type: Task
    Affects Versions: 1.3
            Reporter: Lars Kotthoff
            Priority: Minor


The tests for faceting currently reside in BasicFunctionalityTest (line count 1339). They should be moved to their own class in o.a.s.request to make them easier to find and to reduce the size of BasicFunctionalityTest.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: [jira] Closed: (SOLR-645) Move facet tests into own class

Posted by Chris Hostetter <ho...@fucit.org>.
: 
: FYI, I don't think we tend to "Close" issues.  Typically we leave the status
: as "Resolved"
: 
: not that it is a big deal....

yeah ... Lucene-Java sort of established a precident of leaving issues 
RESOLVED until there was a formal release containing the fix (ie: once hte 
"Fix Version" is released) and then bulk CLOSEing ... but i honeslty don't 
rememebr if we ever did that when 1.1 or 1.2 came out.



-Hoss


Re: [jira] Closed: (SOLR-645) Move facet tests into own class

Posted by Ryan McKinley <ry...@gmail.com>.
FYI, I don't think we tend to "Close" issues.  Typically we leave the  
status as "Resolved"

not that it is a big deal....


On Jul 24, 2008, at 10:01 PM, Lars Kotthoff (JIRA) wrote:

>
>     [ https://issues.apache.org/jira/browse/SOLR-645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel 
>  ]
>
> Lars Kotthoff closed SOLR-645.
> ------------------------------
>
>
>> Move facet tests into own class
>> -------------------------------
>>
>>                Key: SOLR-645
>>                URL: https://issues.apache.org/jira/browse/SOLR-645
>>            Project: Solr
>>         Issue Type: Task
>>   Affects Versions: 1.3
>>           Reporter: Lars Kotthoff
>>           Assignee: Hoss Man
>>           Priority: Minor
>>            Fix For: 1.3
>>
>>        Attachments: SOLR-645.patch
>>
>>
>> The tests for faceting currently reside in BasicFunctionalityTest  
>> (line count 1339). They should be moved to their own class in  
>> o.a.s.request to make them easier to find and to reduce the size of  
>> BasicFunctionalityTest.
>
> -- 
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>


[jira] Closed: (SOLR-645) Move facet tests into own class

Posted by "Lars Kotthoff (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lars Kotthoff closed SOLR-645.
------------------------------


> Move facet tests into own class
> -------------------------------
>
>                 Key: SOLR-645
>                 URL: https://issues.apache.org/jira/browse/SOLR-645
>             Project: Solr
>          Issue Type: Task
>    Affects Versions: 1.3
>            Reporter: Lars Kotthoff
>            Assignee: Hoss Man
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: SOLR-645.patch
>
>
> The tests for faceting currently reside in BasicFunctionalityTest (line count 1339). They should be moved to their own class in o.a.s.request to make them easier to find and to reduce the size of BasicFunctionalityTest.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SOLR-645) Move facet tests into own class

Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hoss Man resolved SOLR-645.
---------------------------

       Resolution: Fixed
    Fix Version/s: 1.3
         Assignee: Hoss Man

Committed revision 679490.

Thanks Lars

> Move facet tests into own class
> -------------------------------
>
>                 Key: SOLR-645
>                 URL: https://issues.apache.org/jira/browse/SOLR-645
>             Project: Solr
>          Issue Type: Task
>    Affects Versions: 1.3
>            Reporter: Lars Kotthoff
>            Assignee: Hoss Man
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: SOLR-645.patch
>
>
> The tests for faceting currently reside in BasicFunctionalityTest (line count 1339). They should be moved to their own class in o.a.s.request to make them easier to find and to reduce the size of BasicFunctionalityTest.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-645) Move facet tests into own class

Posted by "Lars Kotthoff (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lars Kotthoff updated SOLR-645:
-------------------------------

    Attachment: SOLR-645.patch

Patch moving the tests to o.a.s.request.SimpleFacetsTest.

> Move facet tests into own class
> -------------------------------
>
>                 Key: SOLR-645
>                 URL: https://issues.apache.org/jira/browse/SOLR-645
>             Project: Solr
>          Issue Type: Task
>    Affects Versions: 1.3
>            Reporter: Lars Kotthoff
>            Priority: Minor
>         Attachments: SOLR-645.patch
>
>
> The tests for faceting currently reside in BasicFunctionalityTest (line count 1339). They should be moved to their own class in o.a.s.request to make them easier to find and to reduce the size of BasicFunctionalityTest.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.