[jira] [Commented] (ACCUMULO-2197) Building RPMs requires thrift profile to be active

["Christopher Tubbs (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ACCUMULO-2197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13872507#comment-13872507 ] 

Christopher Tubbs commented on ACCUMULO-2197:
---------------------------------------------

I'm not a fan of version-controlling generated code. We've previously discussed removing the option of removing the existing generated code from version control. However, I don't think it's a problem that one maven profile requires another one. Unfortunately, there's no good way to auto-activate one via another, so you just have to specify both. But I don't think this is a bug... I don't see it as an issue at all.

> Building RPMs requires thrift profile to be active
> --------------------------------------------------
>
>                 Key: ACCUMULO-2197
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2197
>             Project: Accumulo
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 1.5.0
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>             Fix For: 1.5.1, 1.6.0
>
>
> The generated sources (cpp, rb, py) for the proxy are only generated when the thrift maven profile is activated. An RPM assembly expects these files to be present. Thus, the following fails:
> {code}
> mvn package -Passemble,rpm -DskipTests
> {code}
> We should probably just include the gen-* variants under src/generated (or similar), commit them to the repository, and let the thrift profile regenerate those files as necessary.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)