[GitHub] jlahoda commented on issue #1091: [NETBEANS-1965] Export public & friend packages for Payara Plugin

[GitBox <gi...@apache.org>]

jlahoda commented on issue #1091: [NETBEANS-1965] Export public & friend packages for Payara Plugin
URL: https://github.com/apache/incubator-netbeans/pull/1091#issuecomment-456181986
 
 
   -1 on the current patch, sorry.
   
   I think adding an (external) module as a friend to modules that already have an external friend is not very controversial.
   
   What is controversial is opening new packages. I think that in all cases, it is necessary to start with a description why a particular package is opened.
   
   The most controversial are cases where a package is opened publicly. Some cases (like opening org.netbeans.modules.openide.windows), seem to be simply undesirable, and any usecase which needed that should be implemented as a proper API enhancement.
   
   Specifically on the org.netbeans.modules.openide.windows package: overriding GlobalActionContextImpl will affect the whole IDE, I believe, so some care needs to be taken. But I don't see why the package must be public. ServiceProvider allows to supersede (mask out) other implementation given their name, no need to make the package public. So what is exactly the usecase?
   
   Thanks.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists