You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/03/30 02:44:34 UTC

[GitHub] [shardingsphere] xhkyyy opened a new pull request #9872: shardingsphere-proxy 4.x doesn't support sql: SELECT * FROM table WHERE Expr IN (VALUE, ...)

xhkyyy opened a new pull request #9872:
URL: https://github.com/apache/shardingsphere/pull/9872


   Fixes #9871.
   
   Changes proposed in this pull request:
   - In the IN statement structure, if an Expr exists, the "visit()" method is executed directly.
   
   I already have tested it, and it worked correctly.
   Please help me to confirm whether there is any problem to change the code in this way? 
   
   -------
   
   > shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/mysql/visitor/MySQLVisitor.java
   
   ![image](https://user-images.githubusercontent.com/2297302/112925135-ef62d480-9143-11eb-84e7-6a04312af9df.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on pull request #9872: shardingsphere-proxy 4.x doesn't support sql: SELECT * FROM table WHERE Expr IN (VALUE, ...)

Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #9872:
URL: https://github.com/apache/shardingsphere/pull/9872#issuecomment-810813656


   Yep, that's why I suggest you test whether the master branch has been fixed or not.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] xhkyyy closed pull request #9872: shardingsphere-proxy 4.x doesn't support sql: SELECT * FROM table WHERE Expr IN (VALUE, ...)

Posted by GitBox <gi...@apache.org>.
xhkyyy closed pull request #9872:
URL: https://github.com/apache/shardingsphere/pull/9872


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on pull request #9872: shardingsphere-proxy 4.x doesn't support sql: SELECT * FROM table WHERE Expr IN (VALUE, ...)

Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #9872:
URL: https://github.com/apache/shardingsphere/pull/9872#issuecomment-810024083


   Hi @xhkyyy ,
   
   Thanks for your PR. Welcome.
   There are many conflict files. Could you give them a look? I assume you need to pull upstream from the master branch, which is the first stop for your PR merged into the master branch.
   BTW, you can still look up similar issues in the issue section to figure out what you are going to fix hasn't been solved in the master branch.
   
   Trista


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] xhkyyy commented on pull request #9872: shardingsphere-proxy 4.x doesn't support sql: SELECT * FROM table WHERE Expr IN (VALUE, ...)

Posted by GitBox <gi...@apache.org>.
xhkyyy commented on pull request #9872:
URL: https://github.com/apache/shardingsphere/pull/9872#issuecomment-810627583


   > Hi @xhkyyy ,
   > 
   > 
   > 
   > Thanks for your PR. Welcome.
   > 
   > There are many conflict files. Could you give them a look? I assume you need to pull upstream from the master branch, which is the first stop for your PR merged into the master branch.
   > 
   > BTW, you can still look up similar issues in the issue section to figure out what you are going to fix hasn't been solved in the master branch.
   > 
   > 
   > 
   > Trista
   
   This PR is for 4.x. 
   The reason why there are a lot of conflicting files is that there is no 4.x branch and I have to commit to the Master branch. 
   I will close this PR later, as I heard from the community that 4.x is no longer maintained.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org