You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/09/20 04:25:08 UTC

[GitHub] merlimat commented on a change in pull request #2593: Add support for running python functions with wheel file

merlimat commented on a change in pull request #2593: Add support for running python functions with wheel file
URL: https://github.com/apache/incubator-pulsar/pull/2593#discussion_r219030874
 
 

 ##########
 File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java
 ##########
 @@ -229,6 +229,10 @@ void processArguments() throws Exception {
                 description = "Path to the main Python file for the function (if the function is written in Python)",
                 listConverter = StringConverter.class)
         protected String pyFile;
+        @Parameter(
+                names = "--pywheel",
 
 Review comment:
   Instead of having a new switch, could we reuse the `--py` and then disambiguate based on the file extension?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services