You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/04/12 22:01:40 UTC

[GitHub] [incubator-druid] jon-wei opened a new pull request #7464: Adjust BufferAggregator.get() impls to return copies

jon-wei opened a new pull request #7464: Adjust BufferAggregator.get() impls to return copies
URL: https://github.com/apache/incubator-druid/pull/7464
 
 
   Fixes #7461
   
   This PR adjusts `HllSketchBuildBufferAggregator` and `BaseBloomFilterBufferAggregator` to return on-heap copies of the aggregator's objects.
   
   I think `DoublesSketchBuildBufferAggregator` is another buffer aggregator that currently returns an object that references the underlying direct buffer, but I wasn't sure how to proceed there. 
   
   @AlexanderSaydakov @leerho What would be the best way to get a copy of the `UpdateDoublesSketch` in `DoublesSketchBuildBufferAggregator.get()`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org