[GitHub] [avro] martin-g commented on a diff in pull request #1843: AVRO-3622 (python) Fix compatibility check for schemas having or missing namespace

[GitBox <gi...@apache.org>]

martin-g commented on code in PR #1843:
URL: https://github.com/apache/avro/pull/1843#discussion_r957262126


##########
lang/py/avro/name.py:
##########
@@ -91,6 +93,10 @@ def __eq__(self, other: object) -> bool:
         """Equality of names is defined on the fullname and is case-sensitive."""
         return hasattr(other, "fullname") and self.fullname == getattr(other, "fullname")
 
+    @property
+    def name(self) -> Optional[str]:

Review Comment:
   Let's add some unit tests for this new method with inputs like:
   1) "Record"
   2) "ns.Record"
   3) "longer.ns.Record"
   4) ".Record"



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org