You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2020/10/14 18:36:06 UTC
[GitHub] [accumulo] ctubbsii commented on a change in pull request #1735: Query if table is Online through Goalstate
ctubbsii commented on a change in pull request #1735:
URL: https://github.com/apache/accumulo/pull/1735#discussion_r504888128
##########
File path: core/src/main/java/org/apache/accumulo/core/client/admin/TableOperations.java
##########
@@ -861,6 +861,23 @@ void online(String tableName)
void online(String tableName, boolean wait)
throws AccumuloSecurityException, AccumuloException, TableNotFoundException;
+ /**
+ *
+ * Check if a table is online through it's current goal state only. Could run into issues if the
+ * current state of the table is inbetween states. If you require a specific state call
+ * online(tableName, true) or offline(tableName, true), this will wait until the table reaches the
+ * desired state before preceeding.
Review comment:
```suggestion
* desired state before proceeding.
```
##########
File path: core/src/main/java/org/apache/accumulo/core/client/admin/TableOperations.java
##########
@@ -861,6 +861,23 @@ void online(String tableName)
void online(String tableName, boolean wait)
throws AccumuloSecurityException, AccumuloException, TableNotFoundException;
+ /**
+ *
+ * Check if a table is online through it's current goal state only. Could run into issues if the
Review comment:
```suggestion
* Check if a table is online through it's current goal state only. Could run into issues if the
```
##########
File path: core/src/main/java/org/apache/accumulo/core/client/admin/TableOperations.java
##########
@@ -861,6 +861,23 @@ void online(String tableName)
void online(String tableName, boolean wait)
throws AccumuloSecurityException, AccumuloException, TableNotFoundException;
+ /**
+ *
+ * Check if a table is online through it's current goal state only. Could run into issues if the
+ * current state of the table is inbetween states. If you require a specific state call
+ * online(tableName, true) or offline(tableName, true), this will wait until the table reaches the
Review comment:
```suggestion
* <code>online(tableName, true)</code> or <code>offline(tableName, true)</code>, this will wait until the table reaches the
```
##########
File path: core/src/main/java/org/apache/accumulo/core/client/admin/TableOperations.java
##########
@@ -861,6 +861,23 @@ void online(String tableName)
void online(String tableName, boolean wait)
throws AccumuloSecurityException, AccumuloException, TableNotFoundException;
+ /**
+ *
+ * Check if a table is online through it's current goal state only. Could run into issues if the
+ * current state of the table is inbetween states. If you require a specific state call
Review comment:
```suggestion
* current state of the table is in between states. If you require a specific state, call
```
##########
File path: core/src/main/java/org/apache/accumulo/core/client/admin/TableOperations.java
##########
@@ -861,6 +861,23 @@ void online(String tableName)
void online(String tableName, boolean wait)
throws AccumuloSecurityException, AccumuloException, TableNotFoundException;
+ /**
+ *
+ * Check if a table is online through it's current goal state only. Could run into issues if the
+ * current state of the table is inbetween states. If you require a specific state call
+ * online(tableName, true) or offline(tableName, true), this will wait until the table reaches the
+ * desired state before preceeding.
+ *
+ * @param tableName
+ * the table to check if online
+ * @throws AccumuloException
+ * when there is a general accumulo error
+ * @return true if table is online
Review comment:
```suggestion
* @return true if table's goal state is online
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org