You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by dstreev <gi...@git.apache.org> on 2016/12/10 01:44:49 UTC

[GitHub] nifi pull request #1316: NIFI-3031 Support Multi-Statement Scripts in the Pu...

GitHub user dstreev opened a pull request:

    https://github.com/apache/nifi/pull/1316

    NIFI-3031 Support Multi-Statement Scripts in the PutHiveQL Processor

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dstreev/nifi-1 NIFI-3031

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1316.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1316
    
----
commit 7a18054dad40e3c21a9b8c7dd760a8e283f12287
Author: David W. Streever <da...@streever.com>
Date:   2016-11-04T15:03:17Z

    PutHiveQL and SelectHiveQL Processor enhancements. Added support for multiple statements in a script.  Options for delimiters, quotes, escaping, include header and alternate header.
    
    Add support in SelectHiveQL to get script content from the Flow File to bring consistency with patterns used for PutHiveQL and support extra query management.
    
    Changed behavior of using Flowfile to match ExecuteSQL.  Handle query delimiter when embedded.  Added test case for embedded delimiter
    
    Formatting and License Header
    
    PutHiveQL and SelectHiveQL Processor enhancements. Added support for multiple statements in a script.  Options for delimiters, quotes, escaping, include header and alternate header.
    
    Add support in SelectHiveQL to get script content from the Flow File to bring consistency with patterns used for PutHiveQL and support extra query management.
    
    Changed behavior of using Flowfile to match ExecuteSQL.  Handle query delimiter when embedded.  Added test case for embedded delimiter
    
    Removing dead code.

commit 31efc23963428c389ca0d6ae01b64ad1e025040e
Author: David W. Streever <da...@streever.com>
Date:   2016-12-10T01:42:35Z

    Comments to Clarify test case.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1316: NIFI-3031 Support Multi-Statement Scripts in the Pu...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/nifi/pull/1316


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1316: NIFI-3031 Support Multi-Statement Scripts in the PutHiveQL...

Posted by mattyb149 <gi...@git.apache.org>.
Github user mattyb149 commented on the issue:

    https://github.com/apache/nifi/pull/1316
  
    +1 LGTM, built and ran unit tests, also tested on a running NiFi the various combinations of CSV settings for SelectHiveQL and a few multi-line multi-statement HiveQL scripts for PutHiveQL.  Thank you for this great contribution!  Merging to master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---