You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Udo Schnurpfeil (JIRA)" <de...@myfaces.apache.org> on 2007/05/09 19:46:15 UTC
[jira] Created: (TOBAGO-393) Create OptimizedResponseWriter to move
the non-standard-complieent stuff to
Create OptimizedResponseWriter to move the non-standard-complieent stuff to
---------------------------------------------------------------------------
Key: TOBAGO-393
URL: https://issues.apache.org/jira/browse/TOBAGO-393
Project: MyFaces Tobago
Issue Type: Sub-task
Reporter: Udo Schnurpfeil
Assigned To: Udo Schnurpfeil
Fix For: 1.0.11
This is needed to make optimizations possible.
e.g. the id-,name-, class-attribute values are not needed to be HTML escaped. But the interface ResponseWriter doesn't allow to write without closing the startElement-tag.
The Tobago renderers may call
OptimizedResponseWriter writer = HtmlRendererUtil.getOptimizedResponseWriter(facesContext);
to get a writer. The static method getOptimizedResponseWriter() may return the TobagoResponseWriter which implements the OptimizedResponseWriter or otherwize return a wrapped object of the given ResponseWriter.
The new OptimizedResponseWriterWrapper class is not optimized, because of the closing-of-the-startElement restriction.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TOBAGO-393) Create OptimizedResponseWriter to
move the non-standard-compliant optimization stuff to
Posted by "Udo Schnurpfeil (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOBAGO-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12494636 ]
Udo Schnurpfeil commented on TOBAGO-393:
----------------------------------------
Okay, thats a good point. But I would prefer:
TobagoResponseWriter for the interface,
TobagoResponseWriterImpl for the default Tobago implementation and
TobagoResponseWriterWrapper for the implementation, which wrappes other standard writers
> Create OptimizedResponseWriter to move the non-standard-compliant optimization stuff to
> ---------------------------------------------------------------------------------------
>
> Key: TOBAGO-393
> URL: https://issues.apache.org/jira/browse/TOBAGO-393
> Project: MyFaces Tobago
> Issue Type: Sub-task
> Reporter: Udo Schnurpfeil
> Assigned To: Udo Schnurpfeil
> Fix For: 1.0.11
>
>
> This is needed to make optimizations possible.
> e.g. the id-,name-, class-attribute values are not needed to be HTML escaped. But the interface ResponseWriter doesn't allow to write without closing the startElement-tag.
> The Tobago renderers may call
> OptimizedResponseWriter writer = HtmlRendererUtil.getOptimizedResponseWriter(facesContext);
> to get a writer. The static method getOptimizedResponseWriter() may return the TobagoResponseWriter which implements the OptimizedResponseWriter or otherwize return a wrapped object of the given ResponseWriter.
> The new OptimizedResponseWriterWrapper class is not optimized, because of the closing-of-the-startElement restriction.
> Remove automatical check of needed escaping from TobagoResponseWriter. Special id-, name-, class-attribute setter should be called.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (TOBAGO-393) Create OptimizedResponseWriter to
move the non-standard-compliant optimization stuff to
Posted by "Udo Schnurpfeil (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOBAGO-393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Udo Schnurpfeil resolved TOBAGO-393.
------------------------------------
Resolution: Fixed
> Create OptimizedResponseWriter to move the non-standard-compliant optimization stuff to
> ---------------------------------------------------------------------------------------
>
> Key: TOBAGO-393
> URL: https://issues.apache.org/jira/browse/TOBAGO-393
> Project: MyFaces Tobago
> Issue Type: Sub-task
> Components: Core
> Reporter: Udo Schnurpfeil
> Assigned To: Udo Schnurpfeil
> Fix For: 1.0.11
>
>
> This is needed to make optimizations possible.
> e.g. the id-,name-, class-attribute values are not needed to be HTML escaped. But the interface ResponseWriter doesn't allow to write without closing the startElement-tag.
> The Tobago renderers may call
> OptimizedResponseWriter writer = HtmlRendererUtil.getOptimizedResponseWriter(facesContext);
> to get a writer. The static method getOptimizedResponseWriter() may return the TobagoResponseWriter which implements the OptimizedResponseWriter or otherwize return a wrapped object of the given ResponseWriter.
> The new OptimizedResponseWriterWrapper class is not optimized, because of the closing-of-the-startElement restriction.
> Remove automatical check of needed escaping from TobagoResponseWriter. Special id-, name-, class-attribute setter should be called.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TOBAGO-393) Create OptimizedResponseWriter to
move the non-standard-compliant optimization stuff to
Posted by "Bernd Bohmann (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOBAGO-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12494574 ]
Bernd Bohmann commented on TOBAGO-393:
--------------------------------------
I think the interface OptimizedResponseWriter should called TobagoResponseWriter because this interface define the extra tobago write methods.
The TobagoResponseWriter should called OptimizedTobagoResponseWriter and the Wrapper for the none TobagoResponseWriterImp maybe
TobagoResponseWriterWrapper or something else.
> Create OptimizedResponseWriter to move the non-standard-compliant optimization stuff to
> ---------------------------------------------------------------------------------------
>
> Key: TOBAGO-393
> URL: https://issues.apache.org/jira/browse/TOBAGO-393
> Project: MyFaces Tobago
> Issue Type: Sub-task
> Reporter: Udo Schnurpfeil
> Assigned To: Udo Schnurpfeil
> Fix For: 1.0.11
>
>
> This is needed to make optimizations possible.
> e.g. the id-,name-, class-attribute values are not needed to be HTML escaped. But the interface ResponseWriter doesn't allow to write without closing the startElement-tag.
> The Tobago renderers may call
> OptimizedResponseWriter writer = HtmlRendererUtil.getOptimizedResponseWriter(facesContext);
> to get a writer. The static method getOptimizedResponseWriter() may return the TobagoResponseWriter which implements the OptimizedResponseWriter or otherwize return a wrapped object of the given ResponseWriter.
> The new OptimizedResponseWriterWrapper class is not optimized, because of the closing-of-the-startElement restriction.
> Remove automatical check of needed escaping from TobagoResponseWriter. Special id-, name-, class-attribute setter should be called.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TOBAGO-393) Create OptimizedResponseWriter to
move the non-standard-compliant optimization stuff to
Posted by "Bernd Bohmann (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOBAGO-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12494648 ]
Bernd Bohmann commented on TOBAGO-393:
--------------------------------------
Ok
> Create OptimizedResponseWriter to move the non-standard-compliant optimization stuff to
> ---------------------------------------------------------------------------------------
>
> Key: TOBAGO-393
> URL: https://issues.apache.org/jira/browse/TOBAGO-393
> Project: MyFaces Tobago
> Issue Type: Sub-task
> Reporter: Udo Schnurpfeil
> Assigned To: Udo Schnurpfeil
> Fix For: 1.0.11
>
>
> This is needed to make optimizations possible.
> e.g. the id-,name-, class-attribute values are not needed to be HTML escaped. But the interface ResponseWriter doesn't allow to write without closing the startElement-tag.
> The Tobago renderers may call
> OptimizedResponseWriter writer = HtmlRendererUtil.getOptimizedResponseWriter(facesContext);
> to get a writer. The static method getOptimizedResponseWriter() may return the TobagoResponseWriter which implements the OptimizedResponseWriter or otherwize return a wrapped object of the given ResponseWriter.
> The new OptimizedResponseWriterWrapper class is not optimized, because of the closing-of-the-startElement restriction.
> Remove automatical check of needed escaping from TobagoResponseWriter. Special id-, name-, class-attribute setter should be called.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.