[GitHub] [flink-kubernetes-operator] pvary commented on a diff in pull request #455: FLINK-30199: Add a script to run Kubernetes Operator e2e tests manually

[GitBox <gi...@apache.org>]

pvary commented on code in PR #455:
URL: https://github.com/apache/flink-kubernetes-operator/pull/455#discussion_r1035737221


##########
e2e-tests/utils.sh:
##########
@@ -265,3 +270,75 @@ function create_namespace() {
   fi;
 
 }
+
+function install_cert_manager() {
+  if [[ -n ${DEBUG} ]]; then
+    kubectl get pods -A
+  fi
+  kubectl apply -f https://github.com/jetstack/cert-manager/releases/download/v1.8.2/cert-manager.yaml
+  kubectl -n cert-manager wait --all=true --for=condition=Available --timeout=300s deploy
+}
+
+function build_image() {
+  export SHELL=/bin/bash
+  export DOCKER_BUILDKIT=1
+  eval $(minikube docker-env)
+  docker build --progress=plain --no-cache -f ./Dockerfile -t flink-kubernetes-operator:ci-latest --progress plain .
+  if [[ -n ${DEBUG} ]]; then
+    docker images
+  fi
+}
+
+function install_operator() {
+  local namespace=$1
+
+  create_namespace flink
+  if [[ -n ${DEBUG} ]]; then
+    debug="--debug"
+  fi
+  helm ${debug} install flink-kubernetes-operator -n ${namespace} helm/flink-kubernetes-operator --set image.repository=flink-kubernetes-operator --set image.tag=ci-latest --create-namespace --set 'watchNamespaces={default,flink}'

Review Comment:
   The namespaces were test parameters even before this change, and the watched namespaces were only an extra param which did not change between the tests.
   
   I tried to keep the existing testing behaviour in this change, and especially do not want to change the tests themselves, so we can be sure that the PR does not cause any unwanted changes.
   
   We might want to do this in a different PR, but even there, I am not sure if it is worth it. I think we gain more by keeping the tests simple and easy to read.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org