You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/13 15:00:39 UTC
[GitHub] [airflow] potiuk opened a new pull request, #26365: Fix static checks from sync_authors script
potiuk opened a new pull request, #26365:
URL: https://github.com/apache/airflow/pull/26365
The #26275 introduced static check problem (isort). This PR fixes it
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #26365: Fix static checks from sync_authors script
Posted by GitBox <gi...@apache.org>.
potiuk commented on code in PR #26365:
URL: https://github.com/apache/airflow/pull/26365#discussion_r969806842
##########
scripts/ci/runners/sync_authors.py:
##########
@@ -53,7 +52,6 @@
with open('ci.yml') as handle:
Review Comment:
No worries. Wa all've been through that :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] norm commented on pull request #26365: Fix static checks from sync_authors script
Posted by GitBox <gi...@apache.org>.
norm commented on PR #26365:
URL: https://github.com/apache/airflow/pull/26365#issuecomment-1245551232
Ugh, those lines came from me rebasing localy poorly *after* having run pre-commit. Sorry. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] norm commented on a diff in pull request #26365: Fix static checks from sync_authors script
Posted by GitBox <gi...@apache.org>.
norm commented on code in PR #26365:
URL: https://github.com/apache/airflow/pull/26365#discussion_r969751596
##########
scripts/ci/runners/sync_authors.py:
##########
@@ -53,7 +52,6 @@
with open('ci.yml') as handle:
Review Comment:
This line should also not have been there (but isn't a crime if it remains)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #26365: Fix static checks from sync_authors script
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26365:
URL: https://github.com/apache/airflow/pull/26365#issuecomment-1245544907
cc: @norm :) Strongly recommend pre-commits (@ashb. I think merged eagerly)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #26365: Fix static checks from sync_authors script
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #26365:
URL: https://github.com/apache/airflow/pull/26365
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org