You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gaston Kleiman <ga...@mesosphere.io> on 2017/09/27 21:50:35 UTC
Review Request 62632: Added a test using Docker, a file URI,
and the DefaultExecutor.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62632/
-----------------------------------------------------------
Review request for mesos, Greg Mann and Vinod Kone.
Bugs: MESOS-7916
https://issues.apache.org/jira/browse/MESOS-7916
Repository: mesos
Description
-------
This test verifies that URIs set on Docker tasks are fetched and made
available to them when started by the DefaultExecutor.
Diffs
-----
src/tests/default_executor_tests.cpp dd1a6ad0d4e2bf74972e15b478652196ee9cd927
Diff: https://reviews.apache.org/r/62632/diff/1/
Testing
-------
`sudo GLOG_v=1 bin/mesos-tests.sh --gtest_filter="*DefaultExecutor*DockerTaskWithFileURI*" --verbose --gtest_repeat=200` passed on GNU/Linux
Thanks,
Gaston Kleiman
Re: Review Request 62632: Added a test using Docker, a file URI,
and the DefaultExecutor.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62632/#review186505
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 62197.
Failed command: `python.exe .\support\apply-reviews.py -n -r 62197`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62632
Relevant logs:
- [apply-review-62197-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62632/logs/apply-review-62197-stdout.log):
```
error: patch failed: src/tests/mesos.hpp:472
error: src/tests/mesos.hpp: patch does not apply
```
- Mesos Reviewbot Windows
On Sept. 27, 2017, 9:50 p.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62632/
> -----------------------------------------------------------
>
> (Updated Sept. 27, 2017, 9:50 p.m.)
>
>
> Review request for mesos, Greg Mann and Vinod Kone.
>
>
> Bugs: MESOS-7916
> https://issues.apache.org/jira/browse/MESOS-7916
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test verifies that URIs set on Docker tasks are fetched and made
> available to them when started by the DefaultExecutor.
>
>
> Diffs
> -----
>
> src/tests/default_executor_tests.cpp dd1a6ad0d4e2bf74972e15b478652196ee9cd927
>
>
> Diff: https://reviews.apache.org/r/62632/diff/1/
>
>
> Testing
> -------
>
> `sudo GLOG_v=1 bin/mesos-tests.sh --gtest_filter="*DefaultExecutor*DockerTaskWithFileURI*" --verbose --gtest_repeat=200` passed on GNU/Linux
>
>
> Thanks,
>
> Gaston Kleiman
>
>
Re: Review Request 62632: Added a test using Docker, a file URI,
and the DefaultExecutor.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62632/#review186722
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Sept. 27, 2017, 9:50 p.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62632/
> -----------------------------------------------------------
>
> (Updated Sept. 27, 2017, 9:50 p.m.)
>
>
> Review request for mesos, Greg Mann and Vinod Kone.
>
>
> Bugs: MESOS-7916
> https://issues.apache.org/jira/browse/MESOS-7916
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test verifies that URIs set on Docker tasks are fetched and made
> available to them when started by the DefaultExecutor.
>
>
> Diffs
> -----
>
> src/tests/default_executor_tests.cpp dd1a6ad0d4e2bf74972e15b478652196ee9cd927
>
>
> Diff: https://reviews.apache.org/r/62632/diff/1/
>
>
> Testing
> -------
>
> `sudo GLOG_v=1 bin/mesos-tests.sh --gtest_filter="*DefaultExecutor*DockerTaskWithFileURI*" --verbose --gtest_repeat=200` passed on GNU/Linux
>
>
> Thanks,
>
> Gaston Kleiman
>
>