You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Ilya Pronin <ip...@twopensource.com> on 2017/09/13 16:40:58 UTC
Review Request 62288: Added Log.Reader.catchup() method to Java
bindings.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62288/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Bugs: MESOS-7973
https://issues.apache.org/jira/browse/MESOS-7973
Repository: mesos
Description
-------
The new method is a wrapper for Log::Reader::catchup() method of the C++
Replicated Log API.
Diffs
-----
src/java/jni/org_apache_mesos_Log.cpp eb0f54be39dfced0dd75dcefa808850f22a34dc6
src/java/src/org/apache/mesos/Log.java f53d9ebeed3fc30e9e9dc642320e94da18eb8ca1
Diff: https://reviews.apache.org/r/62288/diff/1/
Testing
-------
Ran `make check`.
Thanks,
Ilya Pronin
Re: Review Request 62288: Added Log.Reader.catchup() method to Java
bindings.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62288/#review185623
-----------------------------------------------------------
Patch looks great!
Reviews applied: [62283, 62284, 62285, 62286, 62287, 62288]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Sept. 13, 2017, 4:40 p.m., Ilya Pronin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62288/
> -----------------------------------------------------------
>
> (Updated Sept. 13, 2017, 4:40 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-7973
> https://issues.apache.org/jira/browse/MESOS-7973
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The new method is a wrapper for Log::Reader::catchup() method of the C++
> Replicated Log API.
>
>
> Diffs
> -----
>
> src/java/jni/org_apache_mesos_Log.cpp eb0f54be39dfced0dd75dcefa808850f22a34dc6
> src/java/src/org/apache/mesos/Log.java f53d9ebeed3fc30e9e9dc642320e94da18eb8ca1
>
>
> Diff: https://reviews.apache.org/r/62288/diff/1/
>
>
> Testing
> -------
>
> Ran `make check`.
>
>
> Thanks,
>
> Ilya Pronin
>
>
Re: Review Request 62288: Added Log.Reader.catchup() method to Java
bindings.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62288/#review185326
-----------------------------------------------------------
FAIL: Some Mesos tests failed.
Reviews applied: `['62283', '62284', '62285', '62286', '62287', '62288']`
Failed command: `C:\mesos\src\mesos-tests.exe --verbose`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62288
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62288/logs/mesos-tests-stdout.log):
```
[ RUN ] ContentType/SchedulerTest.SchedulerReconnect/0
[ OK ] ContentType/SchedulerTest.SchedulerReconnect/0 (248 ms)
[ RUN ] ContentType/SchedulerTest.SchedulerReconnect/1
[ OK ] ContentType/SchedulerTest.SchedulerReconnect/1 (226 ms)
[----------] 30 tests from ContentType/SchedulerTest (24808 ms total)
[----------] 2 tests from ContentTypeAndSSLConfig/SchedulerSSLTest
[ RUN ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/0
[ OK ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/0 (1116 ms)
[ RUN ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/1
[ OK ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/1 (1090 ms)
[----------] 2 tests from ContentTypeAndSSLConfig/SchedulerSSLTest (2299 ms total)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (134 ms)
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (150 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (347 ms total)
[----------] Global test environment tear-down
[==========] 627 tests from 66 test cases ran. (344374 ms total)
[ PASSED ] 626 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] ContentType/MasterAPITest.EventAuthorizationFiltering/1, where GetParam() = application/json
1 FAILED TEST
YOU HAVE 174 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62288/logs/mesos-tests-stderr.log):
```
I0913 18:45:50.223371 13212 master.cpp:8418] Removing framework da34803e-3bd4-4452-b689-b027db904b21-0000 (default)
I0913 18:45:50.223371 13212 master.cpp:3267] Deactivating framework da34803e-3bd4-4452-b689-b027db904b21-0000 (default)
I0913 18:45:50.224366 13132 hierarchical.cpp:412] Deactivated framework da34803e-3bd4-4452-b689-b027db904b21-0000
I0913 18:45:50.224366 200 slave.cpp:3235] Shutting down framework da34803e-3bd4-4452-b689-b027db904b21-0000
I0913 18:45:50.224366 13212 master.cpp:8993] Updating the state of task 98825eed-960e-45e0-98a6-296ead18725d of framework da34803e-3bd4-4452-b689-b027db904b21-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0913 18:45:50.240365 200 slave.cpp:5731] Shutting down executor 'default' of framework da34803e-3bd4-4452-b689-b027db904b21-0000 (via HTTP)
I0913 18:45:50.243367 13212 master.cpp:9087] Removing task 98825eed-960e-45e0-98a6-296ead18725d with resources [{"allocation_info":{"role":"*"},"name":"cpus","scalar":{"value":2.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"mem","scalar":{"value":1024.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"disk","scalar":{"value":1024.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"ports","ranges":{"range":[{"begin":31000,"end":32000}]},"type":"RANGES"}] of framework da34803e-3bd4-4452-b689-b027db904b21-0000 on agent da34803e-3bd4-4452-b689-b027db904b21-S0 at slave(254)@10.3.1.7:60145 (mesos-bld-s2.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0913 18:45:50.264569 13212 master.cpp:9116] Removing executor 'default' with resources [] of framework da34803e-3bd4-4452-b689-b027db904b21-0000 on agent da34803e-3bd4-4452-b689-b027db904b21-S0 at slave(254)@10.3.1.7:60145 (mesos-bld-s2.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0913 18:45:50.267567 11540 hierarchical.cpp:355] Removed framework da34803e-3bd4-4452-b689-b027db904b21-0000
E0913 18:45:50.268566 200 scheduler.cpp:649] End-Of-File received from master. The master closed the event stream
I0913 18:45:50.269567 11540 scheduler.cpp:444] Re-detecting master
I0913 18:45:50.271569 11540 scheduler.cpp:470] New master detected at master@10.3.1.7:60145
I0913 18:45:50.289409 200 slave.cpp:5407] Executor 'default' of framework da34803e-3bd4-4452-b689-b027db904b21-0000 exited with status 0
I0913 18:45:50.289567 200 slave.cpp:5511] Cleaning up executor 'default' of framework da34803e-3bd4-4452-b689-b027db904b21-0000 (via HTTP)
I0913 18:45:50.292570 200 slave.cpp:5607] Cleaning up framework da34803e-3bd4-4452-b689-b027db904b21-0000
W0913 18:45:50.293586 11540 master.cpp:7021] Ignoring unknown exited executor 'default' of framework da34803e-3bd4-4452-b689-b027db904b21-0000 on agent da34803e-3bd4-4452-b689-b027db904b21-S0 at slave(254)@10.3.1.7:60145 (mesos-bld-s2.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0913 18:45:50.293586 12308 gc.cpp:91] Scheduling 'C:\Users\mesos\AppData\Local\Temp\2\X7jUp6\slaves\da34803e-3bd4-4452-b689-b027db904b21-S0\frameworks\da34803e-3bd4-4452-b689-b027db904b21-0000\executors\default\runs\b12daf26-0aac-47db-a5cc-6deb7d4e8e1e' for gc 6.99999663692148days in the future
I0913 18:45:50.341089 13900 status_update_manager.cpp:285] Closing status update streams for framework da34803e-3bd4-4452-b689-b027db904b21-0000
I0913 18:45:50.341089 12308 gc.cpp:91] Scheduling 'C:\Users\mesos\AppData\Local\Temp\2\X7jUp6\slaves\da34803e-3bd4-4452-b689-b027db904b21-S0\frameworks\da34803e-3bd4-4452-b689-b027db904b21-0000\executors\default' for gc 6.99998505127407days in the future
I0913 18:45:50.342088 200 slave.cpp:861] Agent terminating
I0913 18:45:50.352308 12308 gc.cpp:91] Scheduling 'C:\Users\mesos\AppData\Local\Temp\2\X7jUp6\slaves\da34803e-3bd4-4452-b689-b027db904b21-S0\frameworks\da34803e-3bd4-4452-b689-b027db904b21-0000' for gc 6.9999844781363days in the future
I0913 18:45:50.353308 13132 master.cpp:1321] Agent da34803e-3bd4-4452-b689-b027db904b21-S0 at slave(254)@10.3.1.7:60145 (mesos-bld-s2.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0913 18:45:50.353308 13132 master.cpp:3304] Disconnecting agent da34803e-3bd4-4452-b689-b027db904b21-S0 at slave(254)@10.3.1.7:60145 (mesos-bld-s2.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0913 18:45:50.353308 13132 master.cpp:3323] Deactivating agent da34803e-3bd4-4452-b689-b027db904b21-S0 at slave(254)@10.3.1.7:60145 (mesos-bld-s2.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0913 18:45:50.354310 200 hierarchical.cpp:690] Agent da34803e-3bd4-4452-b689-b027db904b21-S0 deactivated
I0913 18:45:50.378310 14300 master.cpp:1163] Master terminating
I0913 18:45:50.382311 6568 hierarchical.cpp:626] Removed agent da34803e-3bd4-4452-b689-b027db904b21-S0
W0913 18:45:50.386312 11992 master.hpp:2761] Failed to close HTTP pipe for da34803e-3bd4-4452-b689-b027db904b21-0000 (default)
I0913 18:45:51.084358 10880 process.cpp:1068] Failed to accept socket: future discarded
```
- Mesos Reviewbot Windows
On Sept. 13, 2017, 4:40 p.m., Ilya Pronin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62288/
> -----------------------------------------------------------
>
> (Updated Sept. 13, 2017, 4:40 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-7973
> https://issues.apache.org/jira/browse/MESOS-7973
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The new method is a wrapper for Log::Reader::catchup() method of the C++
> Replicated Log API.
>
>
> Diffs
> -----
>
> src/java/jni/org_apache_mesos_Log.cpp eb0f54be39dfced0dd75dcefa808850f22a34dc6
> src/java/src/org/apache/mesos/Log.java f53d9ebeed3fc30e9e9dc642320e94da18eb8ca1
>
>
> Diff: https://reviews.apache.org/r/62288/diff/1/
>
>
> Testing
> -------
>
> Ran `make check`.
>
>
> Thanks,
>
> Ilya Pronin
>
>
Re: Review Request 62288: Added Log.Reader.catchup() method to Java
bindings.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62288/#review194372
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Sept. 13, 2017, 4:40 p.m., Ilya Pronin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62288/
> -----------------------------------------------------------
>
> (Updated Sept. 13, 2017, 4:40 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-7973
> https://issues.apache.org/jira/browse/MESOS-7973
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The new method is a wrapper for Log::Reader::catchup() method of the C++
> Replicated Log API.
>
>
> Diffs
> -----
>
> src/java/jni/org_apache_mesos_Log.cpp eb0f54be39dfced0dd75dcefa808850f22a34dc6
> src/java/src/org/apache/mesos/Log.java f53d9ebeed3fc30e9e9dc642320e94da18eb8ca1
>
>
> Diff: https://reviews.apache.org/r/62288/diff/1/
>
>
> Testing
> -------
>
> Ran `make check`.
>
>
> Thanks,
>
> Ilya Pronin
>
>