You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/05/08 08:12:12 UTC
[GitHub] [airflow] jbampton opened a new issue #15732: Python dictionary contains duplicate keys
jbampton opened a new issue #15732:
URL: https://github.com/apache/airflow/issues/15732
`airflow/providers/apache/hive/hooks/hive.py`
"It is best to think of a dictionary as a set of key: value pairs, with the requirement that the keys are unique (within one dictionary)"
https://docs.python.org/3/tutorial/datastructures.html#dictionaries
<img width="482" alt="Screen Shot 2021-05-08 at 6 03 31 pm" src="https://user-images.githubusercontent.com/418747/117531959-726f2880-b028-11eb-91b1-a394e0cb65a3.png">
<img width="691" alt="Screen Shot 2021-05-08 at 6 03 48 pm" src="https://user-images.githubusercontent.com/418747/117531966-7a2ecd00-b028-11eb-8bf7-33837c86eec9.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #15732: Python dictionary contains duplicate keys
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #15732:
URL: https://github.com/apache/airflow/issues/15732#issuecomment-835199742
There is no need to open issue for that. Can you please just open PR fixing it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #15732: Python dictionary contains duplicate keys
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #15732:
URL: https://github.com/apache/airflow/issues/15732#issuecomment-835202608
And just one more comment - so that you are aware of the "ettqute" and usual approach.
Tthis is a comment which has no impact on the code and can be fixed very easily. There is no reason to pollute the issue space with an issue for that.
Please try not to create such issues as it drags our attention from more important problems.
I close the issue now.,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #15732: Python dictionary contains duplicate keys
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #15732:
URL: https://github.com/apache/airflow/issues/15732#issuecomment-835221058
BTW. Maybe it's time to start learning Python. I think your comments will be much more valuable if you learn Python and will be able to assess how important/easy to fix the issues are.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed issue #15732: Python dictionary contains duplicate keys
Posted by GitBox <gi...@apache.org>.
potiuk closed issue #15732:
URL: https://github.com/apache/airflow/issues/15732
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on issue #15732: Python dictionary contains duplicate keys
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on issue #15732:
URL: https://github.com/apache/airflow/issues/15732#issuecomment-835224023
Doesn't matter. It's a comment. Doctest (but we are not using doctests). https://docs.python.org/3/library/doctest.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jbampton commented on issue #15732: Python dictionary contains duplicate keys
Posted by GitBox <gi...@apache.org>.
jbampton commented on issue #15732:
URL: https://github.com/apache/airflow/issues/15732#issuecomment-835222292
What about the two values in the dictionary ? They are different.
If we delete one key we also lose a value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jbampton commented on issue #15732: Python dictionary contains duplicate keys
Posted by GitBox <gi...@apache.org>.
jbampton commented on issue #15732:
URL: https://github.com/apache/airflow/issues/15732#issuecomment-835212462
I have never really done Python programming.
I was not sure how to fix the problem so I put it up as an issue. It might seem easy to you.
Least I found the issue but since it's now closed it won't get fixed since no one will know about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #15732: Python dictionary contains duplicate keys
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #15732:
URL: https://github.com/apache/airflow/issues/15732#issuecomment-835224023
Does'nt matter. It's a comment. Doctest (but we are not using doctests). https://docs.python.org/3/library/doctest.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #15732: Python dictionary contains duplicate keys
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #15732:
URL: https://github.com/apache/airflow/issues/15732#issuecomment-835220363
Happy to guide you. Just remove one of the duplicated keys with it's value. It's a comment so you will not destroy anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org