[GitHub] [superset] zhaoyongjie commented on pull request #18782: fix: contribution operator meets nan value

[GitBox <gi...@apache.org>]

zhaoyongjie commented on pull request #18782:
URL: https://github.com/apache/superset/pull/18782#issuecomment-1044594731


   > LGTM with a non-blocking comment to think about (as this PR fixes a clear bug I consider my comment mostly a nit). Also, an unrelated observation: I wonder if we should rename "Total" to something that describes more clearly that it's actually the "row" or "x-axis" that we're calculating the contribution for, not the "total", which I feel would be calculated in relation to the sum of the matrix. <img alt="image" width="316" src="https://user-images.githubusercontent.com/33317356/154644101-ca1c15d7-6f31-410b-a7ae-36de05737311.png">
   
   nice catch! done!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org