You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by AhyoungRyu <gi...@git.apache.org> on 2017/02/09 08:16:53 UTC
[GitHub] zeppelin pull request #1999: [MINOR][ZEPPELIN-2090] Remove "zeppelin.interpr...
GitHub user AhyoungRyu opened a pull request:
https://github.com/apache/zeppelin/pull/1999
[MINOR][ZEPPELIN-2090] Remove "zeppelin.interpreters" property related guide msg
### What is this PR for?
As we won't support `zeppelin.interpreters` property anymore (from `0.7.0`), the related msg should be removed accordingly. So I removed it from [docs/manual/interpreterinstallation.md#install-3rd-party-interpreters](https://github.com/apache/zeppelin/blob/master/docs/manual/interpreterinstallation.md#install-3rd-party-interpreters) & [InstallInterpreter.java#L291](https://github.com/apache/zeppelin/blob/master/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/install/InstallInterpreter.java#L291). And rewrite some guide msg like below.
1. After successful installation
- Before
```
Interpreter spark installed under /Users/ahyoungryu/Dev/zeppelin-bin/zeppelin-0.7.0-bin-netinst/interpreter/spark.
Add interpreter class name to 'zeppelin.interpreters' property in your conf/zeppelin-site.xml file
Create interpreter setting in 'Interpreter' menu on GUI. And then you can bind interpreter on your notebook
```
- After
```
Interpreter spark installed under /Users/ahyoungryu/Dev/zeppelin-development/zeppelin/interpreter/spark.
1. Restart Zeppelin
2. Create interpreter setting in 'Interpreter' menu on Zeppelin GUI
3. Then you can bind the interpreter on your note
```
2. If it's skipped (since the interpreter dir already existed)
- Before
```
Directory /Users/ahyoungryu/Dev/zeppelin-bin/zeppelin-0.7.0-bin-netinst/interpreter/flink already exists. Skipping
Create interpreter setting in 'Interpreter' menu on GUI. And then you can bind interpreter on your notebook
```
- After
```
Directory /Users/ahyoungryu/Dev/zeppelin-development/zeppelin/interpreter/flink already exists
Skipped
```
### What type of PR is it?
[Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring]
### What is the Jira issue?
[ZEPPELIN-2090](https://issues.apache.org/jira/browse/ZEPPELIN-2090)
### How should this be tested?
1. Apply this patch and build with
```
$ mvn clean package -DskipTests -pl 'zeppelin-interpreter, zeppelin-zengine, zeppelin-server'
```
2. Remove `interpreter/spark`
```
$ rm -r interpreter/spark
```
3. Install Spark using `install-interpreter.sh`
```
$ ./bin/install-interpreter.sh --name spark --artifact org.apache.zeppelin:zeppelin-spark_2.10:0.7.0
```
Then the msg should be like
<img width="866" alt="screen shot 2017-02-09 at 5 06 27 pm" src="https://cloud.githubusercontent.com/assets/10060731/22774373/1fc93e9e-eeea-11e6-8055-3594e18c7d96.png">
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AhyoungRyu/zeppelin remove/deprecatedTipMsg
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1999.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1999
----
commit 505827364340454b0abf8732628a80017299df74
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2017-02-09T07:10:43Z
Remove deprecated interpreter setting msg
commit c7305d0b97c0c016cf3f891134e67e9890032317
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2017-02-09T07:11:15Z
Rewrite tip msg & remove deprecated setting msg
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1999: [MINOR][ZEPPELIN-2090] Remove "zeppelin.interpreters" ...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1999
Looks nice
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1999: [MINOR][ZEPPELIN-2090] Remove "zeppelin.interpr...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1999
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1999: [MINOR][ZEPPELIN-2090] Remove "zeppelin.interpreters" ...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1999
@jongyoul Thanks for verification!
Only one CI test case failed because of timeout. Merge if there are no more comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---