[GitHub] leventov opened a new issue #7128: Wrong order in BalancerStrategy.pickServersToDrop()

[GitBox <gi...@apache.org>]

leventov opened a new issue #7128: Wrong order in BalancerStrategy.pickServersToDrop()
URL: https://github.com/apache/incubator-druid/issues/7128
 
 
   `ServerHolder` are sorted by *available* space, so `NavigableSet<ServerHolder>` (unless uses `Comparator.reverseOrder()`) have ServerHolders with the *most* available space in the end. Therefore `set.descendingIterator()` suggests to drop segment from least utilized servers first, that's the opposite of what should be done.
   
   However, I think that this default implementation should just be removed because `BalancerStrategy` is not annotated `@ExtensionPoint` and all production implementations of `BalancerStrategy` override this method. Then the signature should be simplified too, accepting any `Collection<ServerHolder>` rather than only `NavigableSet`.
   
   FYI @clintropolis 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org