[GitHub] [spark] MaxGekk commented on a change in pull request #32366: [SPARK-34878][SQL][TESTS] Check actual sizes of year-month and day-time intervals

[GitBox <gi...@apache.org>]

MaxGekk commented on a change in pull request #32366:
URL: https://github.com/apache/spark/pull/32366#discussion_r621119325



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/columnar/ColumnTypeSuite.scala
##########
@@ -79,6 +80,8 @@ class ColumnTypeSuite extends SparkFunSuite with Logging {
     checkActualSize(MAP_TYPE, Map(1 -> "a"), 4 + (8 + 8 + 8 + 8) + (8 + 8 + 8 + 8))
     checkActualSize(STRUCT_TYPE, Row("hello"), 28)
     checkActualSize(CALENDAR_INTERVAL, new CalendarInterval(0, 0, 0), 4 + 4 + 8)
+    checkActualSize(INT, Period.ofMonths(Int.MaxValue).normalized(), 4)
+    checkActualSize(LONG, Duration.ofDays(106751991), 8)

Review comment:
       hmm, why `INT` and `LONG` column types? I wonder what do you construct here:
   ```scala
   val proj = UnsafeProjection.create(Array[DataType](columnType.dataType))
   ```
   Interval types or Int/Long?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org