[GitHub] [superset] etr2460 commented on a change in pull request #18057: fix(Vulnerable dependency): dependency version update for jquery and bootstrap

[GitBox <gi...@apache.org>]

etr2460 commented on a change in pull request #18057:
URL: https://github.com/apache/superset/pull/18057#discussion_r785248973



##########
File path: superset-frontend/package.json
##########
@@ -113,7 +113,7 @@
     "antd": "^4.9.4",
     "array-move": "^2.2.1",
     "babel-plugin-typescript-to-proptypes": "^2.0.0",
-    "bootstrap": "^3.4.1",
+    "bootstrap": "^5.1.1",

Review comment:
       bootstrap is only used to enable menus from FAB to work. So 2 questions:
   1. Do we still need this, or have we replaced the FAB menus everywhere?
   2. Do we need to ensure FAB is using bootstrap v5 before we make this upgrade?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org