You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Dominic Hamon <dh...@twopensource.com> on 2014/04/18 20:17:43 UTC
Review Request 20493: Converted bool returns to Try in stout/os.hpp.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20493/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Ben Mahler.
Repository: mesos-git
Description
-------
see summary
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 38756617ead1b6651e44ab989871ea3e68d130df
Diff: https://reviews.apache.org/r/20493/diff/
Testing
-------
make check
Thanks,
Dominic Hamon
Re: Review Request 20493: Converted bool returns to Try in
stout/os.hpp.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20493/#review48910
-----------------------------------------------------------
Ship it!
Great, looks like os::getenv is the only remaining LOG culprit now!
- Ben Mahler
On July 28, 2014, 7:12 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20493/
> -----------------------------------------------------------
>
> (Updated July 28, 2014, 7:12 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-1236
> https://issues.apache.org/jira/browse/MESOS-1236
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 08251724fbe45431db2c3637c6beec81f5744c4c
>
> Diff: https://reviews.apache.org/r/20493/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 20493: Converted bool returns to Try in
stout/os.hpp.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20493/
-----------------------------------------------------------
(Updated July 29, 2014, 9 a.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
fixed style
Bugs: MESOS-1236
https://issues.apache.org/jira/browse/MESOS-1236
Repository: mesos-git
Description
-------
see summary
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 08251724fbe45431db2c3637c6beec81f5744c4c
3rdparty/libprocess/3rdparty/stout/include/stout/tests/utils.hpp ff4907b38a679e2435e866be642610b234675d54
3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 7fa7346346a33a05fbcd30a11053948eedba4764
Diff: https://reviews.apache.org/r/20493/diff/
Testing
-------
make check
Thanks,
Dominic Hamon
Re: Review Request 20493: Converted bool returns to Try in
stout/os.hpp.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20493/
-----------------------------------------------------------
(Updated July 28, 2014, 3:15 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
remove extra error information.
Bugs: MESOS-1236
https://issues.apache.org/jira/browse/MESOS-1236
Repository: mesos-git
Description
-------
see summary
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 08251724fbe45431db2c3637c6beec81f5744c4c
3rdparty/libprocess/3rdparty/stout/include/stout/tests/utils.hpp ff4907b38a679e2435e866be642610b234675d54
3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 7fa7346346a33a05fbcd30a11053948eedba4764
Diff: https://reviews.apache.org/r/20493/diff/
Testing
-------
make check
Thanks,
Dominic Hamon
Re: Review Request 20493: Converted bool returns to Try in
stout/os.hpp.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20493/#review48911
-----------------------------------------------------------
Sorry, one note I missed about cleaning up the existing error messaging in os::chmod.
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp
<https://reviews.apache.org/r/20493/#comment85689>
Sorry, missed this until I was looking at:
https://reviews.apache.org/r/20494/
This should only be an ErrnoError(), since in general we like to avoid the caller provided information in the callee error messaging.
If the caller then logs the error:
LOG(ERROR) << "Failed to chmod 'path': " << chmod.error();
"Failed to chmod 'path': Failed to changed the mode of the path 'path'"
We will be including redundant information, so we've opted to only include the error reason without caller provided information. In the case of os::su, we're ok to log the subcommand failures because they compose nicely with the caller:
LOG(ERROR) << "Failed to su: " << su.error();
"Failed to su: Failed to getgid: unknown user"
Does this all make sense? If so, let's update the error messaging in os::chmod to clean this up.
- Ben Mahler
On July 28, 2014, 7:12 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20493/
> -----------------------------------------------------------
>
> (Updated July 28, 2014, 7:12 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-1236
> https://issues.apache.org/jira/browse/MESOS-1236
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 08251724fbe45431db2c3637c6beec81f5744c4c
>
> Diff: https://reviews.apache.org/r/20493/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 20493: Converted bool returns to Try in
stout/os.hpp.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20493/
-----------------------------------------------------------
(Updated July 28, 2014, 12:12 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
rebased
Bugs: MESOS-1236
https://issues.apache.org/jira/browse/MESOS-1236
Repository: mesos-git
Description
-------
see summary
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 08251724fbe45431db2c3637c6beec81f5744c4c
Diff: https://reviews.apache.org/r/20493/diff/
Testing
-------
make check
Thanks,
Dominic Hamon
Re: Review Request 20493: Converted bool returns to Try in
stout/os.hpp.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20493/
-----------------------------------------------------------
(Updated April 23, 2014, 2:12 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
added bug ref
Bugs: MESOS-1236
https://issues.apache.org/jira/browse/MESOS-1236
Repository: mesos-git
Description
-------
see summary
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 38756617ead1b6651e44ab989871ea3e68d130df
Diff: https://reviews.apache.org/r/20493/diff/
Testing
-------
make check
Thanks,
Dominic Hamon