[GitHub] [spark] gengliangwang commented on a diff in pull request #42436: [SPARK-44763][SQL] Fix a bug of promoting string as double in binary arithmetic with interval

["gengliangwang (via GitHub)" <gi...@apache.org>]

gengliangwang commented on code in PR #42436:
URL: https://github.com/apache/spark/pull/42436#discussion_r1290657251


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala:
##########
@@ -1096,15 +1096,20 @@ object TypeCoercion extends TypeCoercionBase {
       }
     }
 
+    private def isIntervalType(dt: DataType): Boolean = dt match {
+      case _: CalendarIntervalType | _: AnsiIntervalType => true

Review Comment:
   > Question: there is also DayTimeIntervalType and YearMonthIntervalType et.c and why they are not included in here?
   
   They are of AnsiIntervalType



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org