[GitHub] [james-project] Arsnael commented on pull request #1476: JAMES-3895 Automatically provision default (IMAP) mailboxes

["Arsnael (via GitHub)" <gi...@apache.org>]

Arsnael commented on PR #1476:
URL: https://github.com/apache/james-project/pull/1476#issuecomment-1473094157

   > 1. `org.apache.james.mpt.imapmailbox.suite.Condstore#condstoreShouldBeEnableWhenGivenAndTrue` - this one seems to be unrelated to default mailboxes
   
   Unfortunately I think it is... I ran that test on master branch -> success every time
   I ran that test on your branch -> fails every time...
   
   I tried to take a quick look at why it fails but I'm at a bit of a loss honestly. But it is related to the PR, I'm sorry.
   
   > 2. tests in `org.apache.james.jmap.rfc8621`, for example  `org.apache.james.jmap.rfc8621.contract.BackReferenceContract.resolvingAnUnexistingMethodCallIdShouldFail` - the difference in the length is obvious but the order of the list seems random at best?
   
   Between `assertThatJson` and `isEqualTo` you can add the method `.withOptions(new Options(IGNORING_ARRAY_ORDER))`. It will ignore the order of the list (we didn't clean up everything related to that thanks for spotting it)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org