You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/05/21 02:03:02 UTC
[GitHub] [pulsar] addisonj opened a new pull request #6801: [functions] Don't auth functions worker metrics endpoint
addisonj opened a new pull request #6801:
URL: https://github.com/apache/pulsar/pull/6801
### Motivation
The broker and proxy both allow for hitting the metrics endpoint without auth. The functions
worker should allow that to be configurable as well. This adds an option to
allow for metrics endpoint to allow the endpoint to be hit without auth
Additionally, the functions worker doesn't expose the default prometheus
metrics (such as JVM info, etc).
This commit implements and adds an option to support that
### Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): n
- The public API: n
- The schema: n
- The default values of configurations: n
- The wire protocol: n
- The rest endpoints: n
- The admin cli options: n
- Anything that affects deployment: n
### Documentation
- Does this pull request introduce a new feature? n
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] addisonj commented on pull request #6801: [functions] Don't auth functions worker metrics endpoint
Posted by GitBox <gi...@apache.org>.
addisonj commented on pull request #6801:
URL: https://github.com/apache/pulsar/pull/6801#issuecomment-624288649
@sijie I reworked this a fair bit and also expanded scope so you can get the prometheus metrics
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #6801: [functions] Don't auth functions worker metrics endpoint
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #6801:
URL: https://github.com/apache/pulsar/pull/6801
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on pull request #6801: [functions] Don't auth functions worker metrics endpoint
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #6801:
URL: https://github.com/apache/pulsar/pull/6801#issuecomment-630487194
/pulsarbot run failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] addisonj commented on pull request #6801: [functions] Don't auth functions worker metrics endpoint
Posted by GitBox <gi...@apache.org>.
addisonj commented on pull request #6801:
URL: https://github.com/apache/pulsar/pull/6801#issuecomment-624326475
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] srkukarni commented on a change in pull request #6801: [functions] Don't auth functions worker metrics endpoint
Posted by GitBox <gi...@apache.org>.
srkukarni commented on a change in pull request #6801:
URL: https://github.com/apache/pulsar/pull/6801#discussion_r429425569
##########
File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/worker/WorkerConfig.java
##########
@@ -99,6 +99,17 @@
doc = "The port for serving worker https requests"
)
private Integer workerPortTls;
+ @FieldContext(
+ category = CATEGORY_WORKER,
+ doc = "Whether the '/metrics' endpoint requires authentication. Defaults to false."
Review comment:
does it default to false or true? The doc says one and the default config says other
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on pull request #6801: [functions] Don't auth functions worker metrics endpoint
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #6801:
URL: https://github.com/apache/pulsar/pull/6801#issuecomment-630487298
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie removed a comment on pull request #6801: [functions] Don't auth functions worker metrics endpoint
Posted by GitBox <gi...@apache.org>.
sijie removed a comment on pull request #6801:
URL: https://github.com/apache/pulsar/pull/6801#issuecomment-630487194
/pulsarbot run failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] addisonj commented on issue #6801: [functions] Don't auth functions worker metrics endpoint
Posted by GitBox <gi...@apache.org>.
addisonj commented on issue #6801:
URL: https://github.com/apache/pulsar/pull/6801#issuecomment-618461858
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] addisonj commented on issue #6801: [functions] Don't auth functions worker metrics endpoint
Posted by GitBox <gi...@apache.org>.
addisonj commented on issue #6801:
URL: https://github.com/apache/pulsar/pull/6801#issuecomment-618503075
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #6801: [functions] Don't auth functions worker metrics endpoint
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #6801:
URL: https://github.com/apache/pulsar/pull/6801#issuecomment-638583776
@addisonj Please rebase to the master branch. There are some CI tests fix on the master branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on pull request #6801: [functions] Don't auth functions worker metrics endpoint
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #6801:
URL: https://github.com/apache/pulsar/pull/6801#issuecomment-637211285
@addisonj Can you address the comment?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] addisonj commented on pull request #6801: [functions] Don't auth functions worker metrics endpoint
Posted by GitBox <gi...@apache.org>.
addisonj commented on pull request #6801:
URL: https://github.com/apache/pulsar/pull/6801#issuecomment-619048137
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie closed pull request #6801: [functions] Don't auth functions worker metrics endpoint
Posted by GitBox <gi...@apache.org>.
sijie closed pull request #6801:
URL: https://github.com/apache/pulsar/pull/6801
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] addisonj commented on pull request #6801: [functions] Don't auth functions worker metrics endpoint
Posted by GitBox <gi...@apache.org>.
addisonj commented on pull request #6801:
URL: https://github.com/apache/pulsar/pull/6801#issuecomment-632884994
Whoops, I had changed the default in response to feedback and then forgot
to update the doc
On Fri, May 22, 2020 at 1:42 PM Sanjeev Kulkarni <no...@github.com>
wrote:
> *@srkukarni* commented on this pull request.
> ------------------------------
>
> In
> pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/worker/WorkerConfig.java
> <https://github.com/apache/pulsar/pull/6801#discussion_r429425569>:
>
> > @@ -99,6 +99,17 @@
> doc = "The port for serving worker https requests"
> )
> private Integer workerPortTls;
> + @FieldContext(
> + category = CATEGORY_WORKER,
> + doc = "Whether the '/metrics' endpoint requires authentication. Defaults to false."
>
> does it default to false or true? The doc says one and the default config
> says other
>
> —
> You are receiving this because you were assigned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/pulsar/pull/6801#pullrequestreview-417149715>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAE3LA5FKDU2FWRWIAXQT5TRS3IRZANCNFSM4MOXFK7A>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] addisonj commented on pull request #6801: [functions] Don't auth functions worker metrics endpoint
Posted by GitBox <gi...@apache.org>.
addisonj commented on pull request #6801:
URL: https://github.com/apache/pulsar/pull/6801#issuecomment-624308318
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #6801: [functions] Don't auth functions worker metrics endpoint
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #6801:
URL: https://github.com/apache/pulsar/pull/6801#issuecomment-639180354
@addisonj Please merge the master branch to your branch, #7173 has fix some tests issues. I can't push to your branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] addisonj commented on pull request #6801: [functions] Don't auth functions worker metrics endpoint
Posted by GitBox <gi...@apache.org>.
addisonj commented on pull request #6801:
URL: https://github.com/apache/pulsar/pull/6801#issuecomment-639098596
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org