You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/03 16:53:12 UTC

[GitHub] [airflow] kaxil opened a new pull request #7022: [AIRFLOW-6385] BugFix: SlackAPIPostOperator fails when blocks not set

kaxil opened a new pull request #7022: [AIRFLOW-6385] BugFix: SlackAPIPostOperator fails when blocks not set
URL: https://github.com/apache/airflow/pull/7022
 
 
   **Issue**:
   After upgrade to 1.10.7 all slack notifications became faulty
   SlackAPIPostOperator fails when blocks not set
   
   ```python
       t_slack_ok = SlackAPIPostOperator(
           task_id = 'notify_ok',
           token = Variable.get('slack.token'),
           channel = Variable.get('slack.channel'),
           text = ':rocket: {{ dag.dag_id }} for {{ ds }} has succeeded',
           dag = dag)
   ```
   
   Causing an operator error:
   ```
   [2019-12-28 21:55:14,668] {taskinstance.py:1088} ERROR - Slack API call failed (invalid_blocks_format)
   Traceback (most recent call last):
     File "/usr/local/lib/python3.6/dist-packages/airflow/models/taskinstance.py", line 955, in _run_raw_task
       result = task_copy.execute(context=context)
     File "/usr/local/lib/python3.6/dist-packages/airflow/operators/slack_operator.py", line 85, in execute
       slack.call(self.method, self.api_params)
     File "/usr/local/lib/python3.6/dist-packages/airflow/hooks/slack_hook.py", line 62, in call
       raise AirflowException(msg)
   ```
   **Fix**: 
   It is because the default value is None and `json.dumps(None)` is null  which is not valid for Slack message
   
   ---
   Link to JIRA issue: https://issues.apache.org/jira/browse/AIRFLOW-6385
   
   - [x] Description above provides context of the change
   - [x] Commit message starts with `[AIRFLOW-NNNN]`, where AIRFLOW-NNNN = JIRA ID*
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   (*) For document-only changes, no JIRA issue is needed. Commit message starts `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7022: [AIRFLOW-6385] BugFix: SlackAPIPostOperator fails when blocks not set

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7022: [AIRFLOW-6385] BugFix: SlackAPIPostOperator fails when blocks not set
URL: https://github.com/apache/airflow/pull/7022#issuecomment-570643401
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=h1) Report
   > Merging [#7022](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/e36ecb4c99f9e983d9b9554f03324b5dc108b9c6?src=pr&el=desc) will **decrease** coverage by `0.05%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7022/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7022      +/-   ##
   ==========================================
   - Coverage   84.73%   84.67%   -0.06%     
   ==========================================
     Files         679      679              
     Lines       38598    38598              
   ==========================================
   - Hits        32705    32682      -23     
   - Misses       5893     5916      +23
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/operators/slack\_operator.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvc2xhY2tfb3BlcmF0b3IucHk=) | `100% <100%> (ø)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
   | [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+0.82%)` | :arrow_up: |
   | [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `68.78% <0%> (+0.97%)` | :arrow_up: |
   | [airflow/operators/docker\_operator.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvZG9ja2VyX29wZXJhdG9yLnB5) | `96.84% <0%> (+1.05%)` | :arrow_up: |
   | [airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5) | `77.55% <0%> (+1.53%)` | :arrow_up: |
   | ... and [3 more](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=footer). Last update [e36ecb4...241a05d](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7022: [AIRFLOW-6385] BugFix: SlackAPIPostOperator fails when blocks not set

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7022: [AIRFLOW-6385] BugFix: SlackAPIPostOperator fails when blocks not set
URL: https://github.com/apache/airflow/pull/7022#issuecomment-570643401
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=h1) Report
   > Merging [#7022](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a5030f31b98af24805252f6c47611290aee9c69d?src=pr&el=desc) will **decrease** coverage by `0.06%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7022/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7022      +/-   ##
   ==========================================
   - Coverage   84.73%   84.67%   -0.07%     
   ==========================================
     Files         679      679              
     Lines       38598    38598              
   ==========================================
   - Hits        32706    32682      -24     
   - Misses       5892     5916      +24
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/operators/slack\_operator.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvc2xhY2tfb3BlcmF0b3IucHk=) | `100% <100%> (ø)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
   | [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+0.82%)` | :arrow_up: |
   | [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `68.78% <0%> (+0.97%)` | :arrow_up: |
   | [airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5) | `77.55% <0%> (+1.53%)` | :arrow_up: |
   | [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `96.66% <0%> (+6.66%)` | :arrow_up: |
   | ... and [2 more](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=footer). Last update [a5030f3...241a05d](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7022: [AIRFLOW-6385] BugFix: SlackAPIPostOperator fails when blocks not set

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7022: [AIRFLOW-6385] BugFix: SlackAPIPostOperator fails when blocks not set
URL: https://github.com/apache/airflow/pull/7022#issuecomment-570643401
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=h1) Report
   > Merging [#7022](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/e36ecb4c99f9e983d9b9554f03324b5dc108b9c6?src=pr&el=desc) will **decrease** coverage by `0.05%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7022/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7022      +/-   ##
   ==========================================
   - Coverage   84.73%   84.67%   -0.06%     
   ==========================================
     Files         679      679              
     Lines       38598    38598              
   ==========================================
   - Hits        32705    32682      -23     
   - Misses       5893     5916      +23
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/operators/slack\_operator.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvc2xhY2tfb3BlcmF0b3IucHk=) | `100% <100%> (ø)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
   | [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+0.82%)` | :arrow_up: |
   | [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `68.78% <0%> (+0.97%)` | :arrow_up: |
   | [airflow/operators/docker\_operator.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvZG9ja2VyX29wZXJhdG9yLnB5) | `96.84% <0%> (+1.05%)` | :arrow_up: |
   | [airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5) | `77.55% <0%> (+1.53%)` | :arrow_up: |
   | ... and [3 more](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=footer). Last update [e36ecb4...241a05d](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7022: [AIRFLOW-6385] BugFix: SlackAPIPostOperator fails when blocks not set

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7022: [AIRFLOW-6385] BugFix: SlackAPIPostOperator fails when blocks not set
URL: https://github.com/apache/airflow/pull/7022#issuecomment-570643401
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=h1) Report
   > Merging [#7022](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a5030f31b98af24805252f6c47611290aee9c69d?src=pr&el=desc) will **decrease** coverage by `0.06%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7022/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7022      +/-   ##
   ==========================================
   - Coverage   84.73%   84.67%   -0.07%     
   ==========================================
     Files         679      679              
     Lines       38598    38598              
   ==========================================
   - Hits        32706    32682      -24     
   - Misses       5892     5916      +24
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/operators/slack\_operator.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvc2xhY2tfb3BlcmF0b3IucHk=) | `100% <100%> (ø)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
   | [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+0.82%)` | :arrow_up: |
   | [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `68.78% <0%> (+0.97%)` | :arrow_up: |
   | [airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5) | `77.55% <0%> (+1.53%)` | :arrow_up: |
   | [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `96.66% <0%> (+6.66%)` | :arrow_up: |
   | ... and [2 more](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=footer). Last update [a5030f3...241a05d](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io commented on issue #7022: [AIRFLOW-6385] BugFix: SlackAPIPostOperator fails when blocks not set

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7022: [AIRFLOW-6385] BugFix: SlackAPIPostOperator fails when blocks not set
URL: https://github.com/apache/airflow/pull/7022#issuecomment-570643401
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=h1) Report
   > Merging [#7022](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/e36ecb4c99f9e983d9b9554f03324b5dc108b9c6?src=pr&el=desc) will **decrease** coverage by `0.05%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7022/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7022      +/-   ##
   ==========================================
   - Coverage   84.73%   84.67%   -0.06%     
   ==========================================
     Files         679      679              
     Lines       38598    38598              
   ==========================================
   - Hits        32705    32682      -23     
   - Misses       5893     5916      +23
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/operators/slack\_operator.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvc2xhY2tfb3BlcmF0b3IucHk=) | `100% <100%> (ø)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
   | [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+0.82%)` | :arrow_up: |
   | [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `68.78% <0%> (+0.97%)` | :arrow_up: |
   | [airflow/operators/docker\_operator.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvZG9ja2VyX29wZXJhdG9yLnB5) | `96.84% <0%> (+1.05%)` | :arrow_up: |
   | [airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5) | `77.55% <0%> (+1.53%)` | :arrow_up: |
   | ... and [3 more](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=footer). Last update [e36ecb4...241a05d](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7022: [AIRFLOW-6385] BugFix: SlackAPIPostOperator fails when blocks not set

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7022: [AIRFLOW-6385] BugFix: SlackAPIPostOperator fails when blocks not set
URL: https://github.com/apache/airflow/pull/7022#issuecomment-570643401
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=h1) Report
   > Merging [#7022](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a5030f31b98af24805252f6c47611290aee9c69d?src=pr&el=desc) will **decrease** coverage by `0.06%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7022/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7022      +/-   ##
   ==========================================
   - Coverage   84.73%   84.67%   -0.07%     
   ==========================================
     Files         679      679              
     Lines       38598    38598              
   ==========================================
   - Hits        32706    32682      -24     
   - Misses       5892     5916      +24
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/operators/slack\_operator.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvc2xhY2tfb3BlcmF0b3IucHk=) | `100% <100%> (ø)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
   | [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+0.82%)` | :arrow_up: |
   | [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `68.78% <0%> (+0.97%)` | :arrow_up: |
   | [airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5) | `77.55% <0%> (+1.53%)` | :arrow_up: |
   | [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `96.66% <0%> (+6.66%)` | :arrow_up: |
   | ... and [2 more](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=footer). Last update [a5030f3...241a05d](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7022: [AIRFLOW-6385] BugFix: SlackAPIPostOperator fails when blocks not set

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7022: [AIRFLOW-6385] BugFix: SlackAPIPostOperator fails when blocks not set
URL: https://github.com/apache/airflow/pull/7022#issuecomment-570643401
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=h1) Report
   > Merging [#7022](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a5030f31b98af24805252f6c47611290aee9c69d?src=pr&el=desc) will **decrease** coverage by `0.06%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7022/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7022      +/-   ##
   ==========================================
   - Coverage   84.73%   84.67%   -0.07%     
   ==========================================
     Files         679      679              
     Lines       38598    38598              
   ==========================================
   - Hits        32706    32682      -24     
   - Misses       5892     5916      +24
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/operators/slack\_operator.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvc2xhY2tfb3BlcmF0b3IucHk=) | `100% <100%> (ø)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
   | [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+0.82%)` | :arrow_up: |
   | [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `68.78% <0%> (+0.97%)` | :arrow_up: |
   | [airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5) | `77.55% <0%> (+1.53%)` | :arrow_up: |
   | [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `96.66% <0%> (+6.66%)` | :arrow_up: |
   | ... and [2 more](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=footer). Last update [a5030f3...241a05d](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil commented on a change in pull request #7022: [AIRFLOW-6385] BugFix: SlackAPIPostOperator fails when blocks not set

Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #7022: [AIRFLOW-6385] BugFix: SlackAPIPostOperator fails when blocks not set
URL: https://github.com/apache/airflow/pull/7022#discussion_r362881159
 
 

 ##########
 File path: airflow/operators/slack_operator.py
 ##########
 @@ -128,7 +128,7 @@ def __init__(self,
         self.text = text
         self.icon_url = icon_url
         self.attachments = attachments
-        self.blocks = blocks
+        self.blocks = blocks or []
 
 Review comment:
   Adding test in a sec

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7022: [AIRFLOW-6385] BugFix: SlackAPIPostOperator fails when blocks not set

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7022: [AIRFLOW-6385] BugFix: SlackAPIPostOperator fails when blocks not set
URL: https://github.com/apache/airflow/pull/7022#issuecomment-570643401
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=h1) Report
   > Merging [#7022](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a5030f31b98af24805252f6c47611290aee9c69d?src=pr&el=desc) will **decrease** coverage by `0.06%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7022/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7022      +/-   ##
   ==========================================
   - Coverage   84.73%   84.67%   -0.07%     
   ==========================================
     Files         679      679              
     Lines       38598    38598              
   ==========================================
   - Hits        32706    32682      -24     
   - Misses       5892     5916      +24
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/operators/slack\_operator.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvc2xhY2tfb3BlcmF0b3IucHk=) | `100% <100%> (ø)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
   | [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+0.82%)` | :arrow_up: |
   | [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `68.78% <0%> (+0.97%)` | :arrow_up: |
   | [airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5) | `77.55% <0%> (+1.53%)` | :arrow_up: |
   | [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `96.66% <0%> (+6.66%)` | :arrow_up: |
   | ... and [2 more](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=footer). Last update [a5030f3...241a05d](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil commented on a change in pull request #7022: [AIRFLOW-6385] BugFix: SlackAPIPostOperator fails when blocks not set

Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #7022: [AIRFLOW-6385] BugFix: SlackAPIPostOperator fails when blocks not set
URL: https://github.com/apache/airflow/pull/7022#discussion_r362881159
 
 

 ##########
 File path: airflow/operators/slack_operator.py
 ##########
 @@ -128,7 +128,7 @@ def __init__(self,
         self.text = text
         self.icon_url = icon_url
         self.attachments = attachments
-        self.blocks = blocks
+        self.blocks = blocks or []
 
 Review comment:
   Adding test in a sec

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil merged pull request #7022: [AIRFLOW-6385] BugFix: SlackAPIPostOperator fails when blocks not set

Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #7022: [AIRFLOW-6385] BugFix: SlackAPIPostOperator fails when blocks not set
URL: https://github.com/apache/airflow/pull/7022
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7022: [AIRFLOW-6385] BugFix: SlackAPIPostOperator fails when blocks not set

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7022: [AIRFLOW-6385] BugFix: SlackAPIPostOperator fails when blocks not set
URL: https://github.com/apache/airflow/pull/7022#issuecomment-570643401
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=h1) Report
   > Merging [#7022](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a5030f31b98af24805252f6c47611290aee9c69d?src=pr&el=desc) will **decrease** coverage by `0.06%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7022/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7022      +/-   ##
   ==========================================
   - Coverage   84.73%   84.67%   -0.07%     
   ==========================================
     Files         679      679              
     Lines       38598    38598              
   ==========================================
   - Hits        32706    32682      -24     
   - Misses       5892     5916      +24
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/operators/slack\_operator.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvc2xhY2tfb3BlcmF0b3IucHk=) | `100% <100%> (ø)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
   | [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+0.82%)` | :arrow_up: |
   | [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `68.78% <0%> (+0.97%)` | :arrow_up: |
   | [airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5) | `77.55% <0%> (+1.53%)` | :arrow_up: |
   | [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `96.66% <0%> (+6.66%)` | :arrow_up: |
   | ... and [2 more](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=footer). Last update [a5030f3...241a05d](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7022: [AIRFLOW-6385] BugFix: SlackAPIPostOperator fails when blocks not set

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7022: [AIRFLOW-6385] BugFix: SlackAPIPostOperator fails when blocks not set
URL: https://github.com/apache/airflow/pull/7022#issuecomment-570643401
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=h1) Report
   > Merging [#7022](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a5030f31b98af24805252f6c47611290aee9c69d?src=pr&el=desc) will **decrease** coverage by `0.06%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7022/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7022      +/-   ##
   ==========================================
   - Coverage   84.73%   84.67%   -0.07%     
   ==========================================
     Files         679      679              
     Lines       38598    38598              
   ==========================================
   - Hits        32706    32682      -24     
   - Misses       5892     5916      +24
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/operators/slack\_operator.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvc2xhY2tfb3BlcmF0b3IucHk=) | `100% <100%> (ø)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
   | [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+0.82%)` | :arrow_up: |
   | [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `68.78% <0%> (+0.97%)` | :arrow_up: |
   | [airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5) | `77.55% <0%> (+1.53%)` | :arrow_up: |
   | [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `96.66% <0%> (+6.66%)` | :arrow_up: |
   | ... and [2 more](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=footer). Last update [a5030f3...241a05d](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7022: [AIRFLOW-6385] BugFix: SlackAPIPostOperator fails when blocks not set

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7022: [AIRFLOW-6385] BugFix: SlackAPIPostOperator fails when blocks not set
URL: https://github.com/apache/airflow/pull/7022#issuecomment-570643401
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=h1) Report
   > Merging [#7022](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a5030f31b98af24805252f6c47611290aee9c69d?src=pr&el=desc) will **decrease** coverage by `0.06%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7022/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7022      +/-   ##
   ==========================================
   - Coverage   84.73%   84.67%   -0.07%     
   ==========================================
     Files         679      679              
     Lines       38598    38598              
   ==========================================
   - Hits        32706    32682      -24     
   - Misses       5892     5916      +24
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/operators/slack\_operator.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvc2xhY2tfb3BlcmF0b3IucHk=) | `100% <100%> (ø)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
   | [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+0.82%)` | :arrow_up: |
   | [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `68.78% <0%> (+0.97%)` | :arrow_up: |
   | [airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5) | `77.55% <0%> (+1.53%)` | :arrow_up: |
   | [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `96.66% <0%> (+6.66%)` | :arrow_up: |
   | ... and [2 more](https://codecov.io/gh/apache/airflow/pull/7022/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=footer). Last update [a5030f3...241a05d](https://codecov.io/gh/apache/airflow/pull/7022?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services