You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by "sjanc (via GitHub)" <gi...@apache.org> on 2023/01/23 08:30:14 UTC
[GitHub] [mynewt-core] sjanc opened a new pull request, #2927: ci: Run tests on Windows and Mac
sjanc opened a new pull request, #2927:
URL: https://github.com/apache/mynewt-core/pull/2927
Use matrix to execute builds on all suppored OSes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2927: ci: Run tests on Windows and Mac
Posted by "apache-mynewt-bot (via GitHub)" <gi...@apache.org>.
apache-mynewt-bot commented on PR #2927:
URL: https://github.com/apache/mynewt-core/pull/2927#issuecomment-1400562946
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2927: ci: Run tests on Windows and Mac
Posted by "apache-mynewt-bot (via GitHub)" <gi...@apache.org>.
apache-mynewt-bot commented on PR #2927:
URL: https://github.com/apache/mynewt-core/pull/2927#issuecomment-1400313349
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] michal-narajowski commented on a diff in pull request #2927: ci: Run tests on Windows and Mac
Posted by "michal-narajowski (via GitHub)" <gi...@apache.org>.
michal-narajowski commented on code in PR #2927:
URL: https://github.com/apache/mynewt-core/pull/2927#discussion_r1084179159
##########
.github/test_build_blinky.sh:
##########
@@ -24,6 +24,11 @@ IGNORED_BSPS="ci40 dialog_cmac embarc_emsk hifive1 native-armv7 native-mips\
olimex-pic32-emz64 olimex-pic32-hmz144 pic32mx470_6lp_clicker\
pic32mz2048_wi-fire"
+# native is supported only on Linux (mind the space)
+if [ $RUNNER_OS} != "Linux" ]; then
Review Comment:
```suggestion
if [ ${RUNNER_OS} != "Linux" ]; then
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2927: ci: Run tests on Windows and Mac
Posted by "apache-mynewt-bot (via GitHub)" <gi...@apache.org>.
apache-mynewt-bot commented on PR #2927:
URL: https://github.com/apache/mynewt-core/pull/2927#issuecomment-1400512291
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] sjanc commented on a diff in pull request #2927: ci: Run tests on Windows and Mac
Posted by "sjanc (via GitHub)" <gi...@apache.org>.
sjanc commented on code in PR #2927:
URL: https://github.com/apache/mynewt-core/pull/2927#discussion_r1084165086
##########
.github/test_build_blinky.sh:
##########
@@ -24,6 +24,11 @@ IGNORED_BSPS="ci40 dialog_cmac embarc_emsk hifive1 native-armv7 native-mips\
olimex-pic32-emz64 olimex-pic32-hmz144 pic32mx470_6lp_clicker\
pic32mz2048_wi-fire"
+# native is supported only on Linux (mind the space)
+if [ $RUNNER_OS} != "LLinux" ]; then
Review Comment:
test leftover :) will fixit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2927: ci: Run tests on Windows and Mac
Posted by "apache-mynewt-bot (via GitHub)" <gi...@apache.org>.
apache-mynewt-bot commented on PR #2927:
URL: https://github.com/apache/mynewt-core/pull/2927#issuecomment-1400198245
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] sjanc merged pull request #2927: ci: Run tests on Windows and Mac
Posted by "sjanc (via GitHub)" <gi...@apache.org>.
sjanc merged PR #2927:
URL: https://github.com/apache/mynewt-core/pull/2927
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2927: ci: Run tests on Windows and Mac
Posted by "apache-mynewt-bot (via GitHub)" <gi...@apache.org>.
apache-mynewt-bot commented on PR #2927:
URL: https://github.com/apache/mynewt-core/pull/2927#issuecomment-1400000020
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2927: ci: Run tests on Windows and Mac
Posted by "apache-mynewt-bot (via GitHub)" <gi...@apache.org>.
apache-mynewt-bot commented on PR #2927:
URL: https://github.com/apache/mynewt-core/pull/2927#issuecomment-1400116877
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] michal-narajowski commented on a diff in pull request #2927: ci: Run tests on Windows and Mac
Posted by "michal-narajowski (via GitHub)" <gi...@apache.org>.
michal-narajowski commented on code in PR #2927:
URL: https://github.com/apache/mynewt-core/pull/2927#discussion_r1084106766
##########
.github/test_build_blinky.sh:
##########
@@ -24,6 +24,11 @@ IGNORED_BSPS="ci40 dialog_cmac embarc_emsk hifive1 native-armv7 native-mips\
olimex-pic32-emz64 olimex-pic32-hmz144 pic32mx470_6lp_clicker\
pic32mz2048_wi-fire"
+# native is supported only on Linux (mind the space)
+if [ $RUNNER_OS} != "LLinux" ]; then
Review Comment:
Typos?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org