[GitHub] [beam] Abacn commented on a diff in pull request #26618: #26395 Disabling possibly unnecessary prefetching during GroupIntoBatches by using an experimental flag

["Abacn (via GitHub)" <gi...@apache.org>]

Abacn commented on code in PR #26618:
URL: https://github.com/apache/beam/pull/26618#discussion_r1192474064


##########
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/GroupIntoBatches.java:
##########
@@ -110,6 +112,10 @@
 public class GroupIntoBatches<K, InputT>
     extends PTransform<PCollection<KV<K, InputT>>, PCollection<KV<K, Iterable<InputT>>>> {
 
+  /** Experiment to "avoid possibly unnecessary prefetching". */
+  public static final String AVOID_POSSIBLY_UNNECESSARY_PREFETCHING =
+      "avoid_possibly_unnecessary_prefetching";

Review Comment:
   consider a descriptive naming: disable_groupintobatches_preferch



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org